Set transport macro for local mechanisms#4777
Merged
MrAnno merged 14 commits intosyslog-ng:masterfrom Jan 31, 2024
Merged
Conversation
Contributor
|
Build FAILURE |
bazsi
force-pushed
the
set-transport-macro-for-local-mechanisms
branch
from
f4037e4 to
96e3c62
Compare
Collaborator
Author
|
@mbonsack can you have a look on these transport values? I don't think we would see these too much, but I wanted to make sure that $TRANSPORT points to the ingest mechanism even if a local transport is used. Thanks |
Merged
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
The affile plugin implements file(), pipe(), stdin() and stdout() drivers. Make sure all of the source drivers set $TRANSPORT properly. Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
bazsi
force-pushed
the
set-transport-macro-for-local-mechanisms
branch
from
96e3c62 to
0f01f71
Compare
Collaborator
Author
|
@HofiOne I added code to set $TRANSPORT in the case for both darwin-oslog() and darwin-oslog-stream() a review on that piece would be welcome. |
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
bazsi
force-pushed
the
set-transport-macro-for-local-mechanisms
branch
from
0f01f71 to
ccca5c1
Compare
MrAnno
reviewed
Jan 30, 2024
| static inline void | ||
| log_msg_set_value_to_string(LogMessage *self, NVHandle handle, const gchar *literal_string) | ||
| { | ||
| log_msg_set_value(self, handle, literal_string, strlen(literal_string)); |
Collaborator
There was a problem hiding this comment.
We call this on the hot path, for every message, when setting the $TRANSPORT macro.
I think it could be better if we'd call log_msg_set_value() with sizeof() or introduce log_msg_set_value_to_literal_string as a macro to avoid this per-message strlen() call.
Collaborator
Author
There was a problem hiding this comment.
I didn't check but this should be inlined with the same effect.
It may not, unless we compile using -O3
MrAnno
approved these changes
Jan 31, 2024
alltilla
added a commit
to alltilla/syslog-ng
that referenced
this pull request
Feb 12, 2024
Signed-off-by: Attila Szakacs <[email protected]>
MrAnno
added a commit
that referenced
this pull request
Feb 12, 2024
bshifter
pushed a commit
to bshifter/syslog-ng
that referenced
this pull request
Feb 19, 2024
Signed-off-by: Attila Szakacs <[email protected]>
bshifter
pushed a commit
to bshifter/syslog-ng
that referenced
this pull request
Feb 22, 2024
Signed-off-by: Attila Szakacs <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rounds up the setting of the $TRANSPORT macro for local log transport mechanisms.
The convention used is: local+
+1 mqtt now sets $TRANSPORT to mqtt