Merged
Conversation
As `_map_header_of_entry_from_handle()` may fail, the return value should be checked. Signed-off-by: Szilárd Parrag <[email protected]>
Contributor
|
No news file has been detected. Please write one, if applicable. |
Contributor
|
Build FAILURE |
Collaborator
Author
|
@kira-syslogng retest this please; |
Collaborator
|
Is there an actual occurrence of this bug? How was this found? Otherwise this looks good to me. |
bazsi
approved these changes
Sep 1, 2022
Collaborator
Author
|
We've had a crash report, and we found it during the investigation. (The reason why I opened it as draft was because I wanted to find code paths like this (e.g, the return value of a function that may fail is used without checks), but some of them are not that straightforward to validate, so I will merge this PR, and open a separate one for those.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As
_map_header_of_entry_from_handle()may fail, the return valueshould be checked.
It could cause a crash, if the the handle or the entry was corrupted.
Signed-off-by: Szilárd Parrag [email protected]