Repository navigation
Commit 21c11f3
committed
Provide a module spec for string-based template modules
Fixed issue where formatting a traceback for an exception raised inside
a template compiled from a string would emit "DeprecationWarning: Module
globals is missing a __spec__.loader" on Python 3.15. A module built
from types.ModuleType alone has __spec__ and __loader__ present in its
namespace but set to None, and Python 3.15's linecache._bless_my_loader()
warns when it finds a __spec__ without a loader. Its early return for
synthetic modules only applies when __spec__ is absent entirely, so
template modules fell through to the warning. As linecache is consulted
for every frame while a traceback is built, the warning is raised from
inside traceback formatting, which destroys the error report for the
common configuration of turning warnings into errors.
Template modules are now given a spec whose loader can return the
generated module source. Beyond silencing the warning, this makes the
generated source lines available to linecache, so tracebacks produced by
the standard library now display the generated line for template frames
where previously no source could be shown.
Fixes: sqlalchemy#437
Change-Id: I838eadefeaf073ad60930ad7a025dd11393e2b6d1 parent 3c1b6a3 commit 21c11f3
3 files changed
Lines changed: 102 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| 11 | + | |
10 | 12 | | |
11 | 13 | | |
12 | 14 | | |
| |||
662 | 664 | | |
663 | 665 | | |
664 | 666 | | |
| 667 | + | |
| 668 | + | |
| 669 | + | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
| 676 | + | |
| 677 | + | |
| 678 | + | |
| 679 | + | |
| 680 | + | |
| 681 | + | |
| 682 | + | |
| 683 | + | |
| 684 | + | |
| 685 | + | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
| 689 | + | |
| 690 | + | |
665 | 691 | | |
666 | 692 | | |
667 | 693 | | |
| |||
670 | 696 | | |
671 | 697 | | |
672 | 698 | | |
| 699 | + | |
| 700 | + | |
| 701 | + | |
673 | 702 | | |
674 | 703 | | |
675 | 704 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
| 3 | + | |
2 | 4 | | |
3 | 5 | | |
4 | 6 | | |
5 | 7 | | |
| 8 | + | |
6 | 9 | | |
7 | 10 | | |
8 | 11 | | |
| |||
371 | 374 | | |
372 | 375 | | |
373 | 376 | | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
0 commit comments