Format CValidationState properly in all cases

jkczyz · jkczyz · commit 72f3227c8381 · 2020-01-03T11:37:26.000-08:00
FormatStateMessage does not properly handle the case where
CValidationState::IsValid() returns true. Use "Valid" for the state in
this case.
diff --git a/src/util/validation.cpp b/src/util/validation.cpp
@@ -11,6 +11,10 @@
 /** Convert ValidationState to a human-readable message for logging */
 std::string FormatStateMessage(const ValidationState &state)
 {
+    if (state.IsValid()) {
+        return "Valid";
+    }
+
     return strprintf("%s%s",
         state.GetRejectReason(),
         state.GetDebugMessage().empty() ? "" : ", "+state.GetDebugMessage());
