SYS-324 Move "syscoin" related files "services" folder (3.3.0) #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshchepkov
requested review from
jnessbcf,
radubcf and
willyko
and removed request for
dwasyluk
oshchepkov
deleted the
SYS-324-Move-syscoin-files-into-services-folder-(3.0.3-prep)
branch
sidhujag
pushed a commit
that referenced
this pull request
Apr 3, 2022
… syntax for numbers with a unit symbol" 0c64401 Revert "qt: Do not use QObject::tr plural syntax for numbers with a unit symbol" (Luke Dashjr) Pull request description: Apparently this got forgotten. Maybe too late for 23.x (it's a bugfix, but changes translation strings). This reverts commit 3adde72 (#296) per [GChuf](bitcoin-core/gui#296 (comment)) >I can confirm for slovenian and other slavic languages that we do have 3 or 4 different ways of saying "%n GB needed%, depending on the actual number of gigabytes. Similar to english "is/are". There's no way to cover all cases ... this is exactly why transifex allows you to have more than 2 options. ACKs for top commit: hebasto: ACK 0c64401, I have reviewed the code and it looks OK, I agree it can be merged. Tree-SHA512: c01bae44a32b3ec324f2f9b8e4923bbb2e83bbd1460b745c5c911b98a9b2806fcbf815cfb19a1f1a7038c5c14312e102e7df8744c9002ef784b36d158e08eb14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.3.0
Moved the following files to "src/services" folder:
alias.h / alias.cpp
offer.h / offer.cpp
cert.h / cert.cpp
ranges.h / ranges.cpp
graph.h / graph.cpp
asset.h / asset.cpp
assetallocation.h / assetallocation.cpp
escrow.h / escrow.cpp
Unit/integration tests passed:
