Skip to content

Revert "[SYS-252] listassetallocationtransactions" #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sidhujag merged 1 commit into from
Aug 7, 2018
Merged

Revert "[SYS-252] listassetallocationtransactions" #262

sidhujag merged 1 commit into from
Aug 7, 2018

Conversation

@sidhujag
Copy link
Member

@sidhujag sidhujag commented Aug 7, 2018

Reverts #254

@sidhujag sidhujag merged commit ceef76f into dev-3.x-prep-3.0.7 Aug 7, 2018
@sidhujag sidhujag deleted the revert-254-sys-252-laatrpcfix branch August 7, 2018 17:28
sidhujag pushed a commit that referenced this pull request Apr 19, 2021
@hebasto
Merge bitcoin-core/gui#276: Elide long strings in their middle in the…
3b2479c 
… Peers tab

4e06133 qt: Elide long strings in their middle in the Peers tab (Hennadii Stepanov)

Pull request description:

  The eliding of long addresses (Onion v3 etc) in the Peers tab in their middle was [discussed](bitcoin-core/gui#262 (comment)) in #262.

  On master (f0fa324):
  ![DeepinScreenshot_select-area_20210410141435](https://user-images.githubusercontent.com/32963518/114267903-24eea400-9a07-11eb-8c80-99f68d5cc522.png)

  With this PR:
  ![DeepinScreenshot_select-area_20210410140430](https://user-images.githubusercontent.com/32963518/114267796-83675280-9a06-11eb-921f-ca47c2075496.png)

  This PR suggests the minimal diff to achieve the goal. OTOH, this change in behavior is common for all columns in the Peers table, but it seems harmless.

ACKs for top commit:
  jarolrod:
    tACK 4e06133
  promag:
    Code review ACK 4e06133.

Tree-SHA512: 1d5a62afb1152029e69fccea2ae53dcb262a91724a5c03dfc4de8c409b280814d0c211c2f9a71f1a6e927f4ed571ba4ac311de9de8ebb797eaf1051674241bdb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwasyluk dwasyluk Awaiting requested review from dwasyluk

@sschepis sschepis Awaiting requested review from sschepis

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sidhujag