Skip to content

scanner/list updates #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sidhujag merged 4 commits into from
Jun 21, 2018
Merged

scanner/list updates #224

sidhujag merged 4 commits into from
Jun 21, 2018

Conversation

@doublesharp
Copy link

@doublesharp doublesharp commented Jun 20, 2018

  • use count=0 to return all results by setting to INT_MAX
  • check that input parameters are valid
  • remove "options" key and use options as root keys for ease of use
  • fix CLI examples (missing single quotes, extra double quotes)
  • update help text

@doublesharp
scanaliases updates
ee32e0b 
* use count=0 to return all results by setting to INT_MAX
* check that input parameters are valid
* remove "options" key and use options as root keys for ease of use
* fix CLI examples (missing single quotes, extra double quotes)
* update help text
@doublesharp
fix infinite loop, rename scan*->list*, input updates
f9f24e1 
* fix infinite loop triggered by not calling Next() on iterator
* use count=0 to return all results by setting to INT_MAX
* check that input parameters are valid
* remove "options" key and use options as root keys for ease of use
* fix CLI examples (missing single quotes, extra double quotes)
update help text
@sidhujag
Copy link
Member

sidhujag commented Jun 21, 2018

utACK

@doublesharp doublesharp changed the title scanaliases updates scanner/list updates Jun 21, 2018
@sidhujag sidhujag merged commit 8bd26f7 into syscoin:dev-3.x-prep-3.0.6 Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sidhujag sidhujag sidhujag approved these changes

@dwasyluk dwasyluk Awaiting requested review from dwasyluk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@doublesharp @sidhujag