test: Restore unlimited timeout in IndexWaitSynced

MarcoFalke · MarcoFalke · commit fabed7eb7966 · 2023-07-06T14:19:59.000+02:00
The timeout was unlimited before, so just restore that value for now: bitcoin#27988 (comment)
diff --git a/src/test/util/index.cpp b/src/test/util/index.cpp
@@ -5,14 +5,11 @@
 #include <test/util/index.h>
 
 #include <index/base.h>
-#include <util/check.h>
 #include <util/time.h>
 
-void IndexWaitSynced(BaseIndex& index)
+void IndexWaitSynced(const BaseIndex& index)
 {
-    const auto timeout{SteadyClock::now() + 120s};
     while (!index.BlockUntilSyncedToCurrentChain()) {
-        Assert(timeout > SteadyClock::now());
         UninterruptibleSleep(100ms);
     }
 }
diff --git a/src/test/util/index.h b/src/test/util/index.h
@@ -8,6 +8,6 @@
 class BaseIndex;
 
 /** Block until the index is synced to the current chain */
-void IndexWaitSynced(BaseIndex& index);
+void IndexWaitSynced(const BaseIndex& index);
 
 #endif // BITCOIN_TEST_UTIL_INDEX_H

Original file line number	Diff line number	Diff line change
`@@ -5,14 +5,11 @@`
`5`	`5`	`#include <test/util/index.h>`
`6`	`6`
`7`	`7`	`#include <index/base.h>`
`8`		`-#include <util/check.h>`
`9`	`8`	`#include <util/time.h>`
`10`	`9`
`11`		`-void IndexWaitSynced(BaseIndex& index)`
	`10`	`+void IndexWaitSynced(const BaseIndex& index)`
`12`	`11`	`{`
`13`		`- const auto timeout{SteadyClock::now() + 120s};`
`14`	`12`	`while (!index.BlockUntilSyncedToCurrentChain()) {`
`15`		`- Assert(timeout > SteadyClock::now());`
`16`	`13`	`UninterruptibleSleep(100ms);`
`17`	`14`	`}`
`18`	`15`	`}`