test: Avoid connecting to real network when running tests

MarcoFalke · MarcoFalke · commit fa730e915766 · 2021-02-21T11:02:58.000+01:00
Can be reviewed with --word-diff-regex=.
diff --git a/test/functional/feature_config_args.py b/test/functional/feature_config_args.py
@@ -151,6 +151,10 @@ def test_networkactive(self):
     def test_seed_peers(self):
         self.log.info('Test seed peers')
         default_data_dir = self.nodes[0].datadir
+        # Only regtest has no fixed seeds. To avoid connections to random
+        # nodes, regtest is the only network where it is safe to enable
+        # -fixedseeds in tests
+        util.assert_equal(self.nodes[0].getblockchaininfo()['chain'],'regtest')
         self.stop_node(0)
 
         # No peers.dat exists and -dnsseed=1
@@ -160,10 +164,12 @@ def test_seed_peers(self):
         start = int(time.time())
         with self.nodes[0].assert_debug_log(expected_msgs=[
                 "Loaded 0 addresses from peers.dat",
-                "0 addresses found from DNS seeds"]):
-            self.start_node(0, extra_args=['-dnsseed=1 -mocktime={}'.format(start)])
+                "0 addresses found from DNS seeds",
+        ]):
+            self.start_node(0, extra_args=['-dnsseed=1', '-fixedseeds=1', f'-mocktime={start}'])
         with self.nodes[0].assert_debug_log(expected_msgs=[
-                "Adding fixed seeds as 60 seconds have passed and addrman is empty"]):
+                "Adding fixed seeds as 60 seconds have passed and addrman is empty",
+        ]):
             self.nodes[0].setmocktime(start + 65)
         self.stop_node(0)
 
@@ -174,8 +180,9 @@ def test_seed_peers(self):
         with self.nodes[0].assert_debug_log(expected_msgs=[
                 "Loaded 0 addresses from peers.dat",
                 "DNS seeding disabled",
-                "Adding fixed seeds as -dnsseed=0, -addnode is not provided and all -seednode(s) attempted\n"]):
-            self.start_node(0, extra_args=['-dnsseed=0'])
+                "Adding fixed seeds as -dnsseed=0, -addnode is not provided and all -seednode(s) attempted\n",
+        ]):
+            self.start_node(0, extra_args=['-dnsseed=0', '-fixedseeds=1'])
         assert time.time() - start < 60
         self.stop_node(0)
 
@@ -186,7 +193,8 @@ def test_seed_peers(self):
         with self.nodes[0].assert_debug_log(expected_msgs=[
                 "Loaded 0 addresses from peers.dat",
                 "DNS seeding disabled",
-                "Fixed seeds are disabled"]):
+                "Fixed seeds are disabled",
+        ]):
             self.start_node(0, extra_args=['-dnsseed=0', '-fixedseeds=0'])
         assert time.time() - start < 60
         self.stop_node(0)
@@ -197,13 +205,14 @@ def test_seed_peers(self):
         start = int(time.time())
         with self.nodes[0].assert_debug_log(expected_msgs=[
                 "Loaded 0 addresses from peers.dat",
-                "DNS seeding disabled"]):
-            self.start_node(0, extra_args=['-dnsseed=0', '-addnode=fakenodeaddr -mocktime={}'.format(start)])
+                "DNS seeding disabled",
+        ]):
+            self.start_node(0, extra_args=['-dnsseed=0', '-fixedseeds=1', '-addnode=fakenodeaddr', f'-mocktime={start}'])
         with self.nodes[0].assert_debug_log(expected_msgs=[
-                "Adding fixed seeds as 60 seconds have passed and addrman is empty"]):
+                "Adding fixed seeds as 60 seconds have passed and addrman is empty",
+        ]):
             self.nodes[0].setmocktime(start + 65)
 
-
     def run_test(self):
         self.test_log_buffer()
         self.test_args_log()
diff --git a/test/functional/test_framework/util.py b/test/functional/test_framework/util.py
@@ -368,6 +368,7 @@ def write_config(config_path, *, n, chain, extra_config=""):
         f.write("keypool=1\n")
         f.write("discover=0\n")
         f.write("dnsseed=0\n")
+        f.write("fixedseeds=0\n")
         f.write("listenonion=0\n")
         f.write("printtoconsole=0\n")
         f.write("upnp=0\n")
