build: remove deprecated key from macOS Info.plist

fanquake · fanquake · commit c0bc453135b3 · 2019-12-31T21:39:05.000+03:00
Note that the current release binaries don't show incorrect version numbers anywhere in the GUI, and we haven't reintroduced the issue that bitcoin#14701 fixed. This is just swapping a deprecated field for a newer one and removing the additional version number.
diff --git a/share/qt/Info.plist.in b/share/qt/Info.plist.in
@@ -16,7 +16,7 @@
   <key>CFBundlePackageType</key>
   <string>APPL</string>
 
-  <key>CFBundleGetInfoString</key>
+  <key>NSHumanReadableCopyright</key>
   <string>@CLIENT_VERSION_MAJOR@.@CLIENT_VERSION_MINOR@.@CLIENT_VERSION_REVISION@.@CLIENT_VERSION_BUILD@, Copyright © 2009-@COPYRIGHT_YEAR@ @COPYRIGHT_HOLDERS_FINAL@</string>
 
   <key>CFBundleShortVersionString</key>
