RPC: createwallet: Nicer error message if descriptor wallet requested and sqlite support not compiled in

luke-jr · luke-jr · commit bbb42a68961a · 2020-10-20T13:44:43.000Z
diff --git a/src/wallet/rpcwallet.cpp b/src/wallet/rpcwallet.cpp
@@ -2740,6 +2740,9 @@ static RPCHelpMan createwallet()
         flags |= WALLET_FLAG_AVOID_REUSE;
     }
     if (!request.params[5].isNull() && request.params[5].get_bool()) {
+#ifndef USE_SQLITE
+        throw JSONRPCError(RPC_WALLET_ERROR, "Compiled without sqlite support (required for descriptor wallets)");
+#endif
         flags |= WALLET_FLAG_DESCRIPTORS;
         warnings.emplace_back(Untranslated("Wallet is an experimental descriptor wallet"));
     }

Original file line number	Diff line number	Diff line change
`@@ -2740,6 +2740,9 @@ static RPCHelpMan createwallet()`
`2740`	`2740`	`flags \|= WALLET_FLAG_AVOID_REUSE;`
`2741`	`2741`	`}`
`2742`	`2742`	`if (!request.params[5].isNull() && request.params[5].get_bool()) {`
	`2743`	`+#ifndef USE_SQLITE`
	`2744`	`+ throw JSONRPCError(RPC_WALLET_ERROR, "Compiled without sqlite support (required for descriptor wallets)");`
	`2745`	`+#endif`
`2743`	`2746`	`flags \|= WALLET_FLAG_DESCRIPTORS;`
`2744`	`2747`	`warnings.emplace_back(Untranslated("Wallet is an experimental descriptor wallet"));`
`2745`	`2748`	`}`