init: disallow reindex-chainstate when pruning

mzumsande · mzumsande · commit b2813980b810 · 2022-03-24T13:03:40.000+01:00
This fixes a bug where the node would be stuck in an
endless loop when combining these parameters.
diff --git a/src/init.cpp b/src/init.cpp
@@ -853,12 +853,14 @@ bool AppInitParameterInteraction(const ArgsManager& args)
         nLocalServices = ServiceFlags(nLocalServices | NODE_COMPACT_FILTERS);
     }
 
-    // if using block pruning, then disallow txindex and coinstatsindex
     if (args.GetIntArg("-prune", 0)) {
         if (args.GetBoolArg("-txindex", DEFAULT_TXINDEX))
             return InitError(_("Prune mode is incompatible with -txindex."));
         if (args.GetBoolArg("-coinstatsindex", DEFAULT_COINSTATSINDEX))
             return InitError(_("Prune mode is incompatible with -coinstatsindex."));
+        if (args.GetBoolArg("-reindex-chainstate", false)) {
+            return InitError(_("Prune mode is incompatible with -reindex-chainstate. Use full -reindex instead."));
+        }
     }
 
     // If -forcednsseed is set to true, ensure -dnsseed has not been set to false
diff --git a/test/functional/feature_pruning.py b/test/functional/feature_pruning.py
@@ -141,6 +141,10 @@ def test_invalid_command_line_options(self):
             expected_msg='Error: Prune mode is incompatible with -coinstatsindex.',
             extra_args=['-prune=550', '-coinstatsindex'],
         )
+        self.nodes[0].assert_start_raises_init_error(
+            expected_msg='Error: Prune mode is incompatible with -reindex-chainstate. Use full -reindex instead.',
+            extra_args=['-prune=550', '-reindex-chainstate'],
+        )
 
     def test_height_min(self):
         assert os.path.isfile(os.path.join(self.prunedir, "blk00000.dat")), "blk00000.dat is missing, pruning too early"

Original file line number	Diff line number	Diff line change
`@@ -853,12 +853,14 @@ bool AppInitParameterInteraction(const ArgsManager& args)`
`853`	`853`	`nLocalServices = ServiceFlags(nLocalServices \| NODE_COMPACT_FILTERS);`
`854`	`854`	`}`
`855`	`855`
`856`		`- // if using block pruning, then disallow txindex and coinstatsindex`
`857`	`856`	`if (args.GetIntArg("-prune", 0)) {`
`858`	`857`	`if (args.GetBoolArg("-txindex", DEFAULT_TXINDEX))`
`859`	`858`	`return InitError(_("Prune mode is incompatible with -txindex."));`
`860`	`859`	`if (args.GetBoolArg("-coinstatsindex", DEFAULT_COINSTATSINDEX))`
`861`	`860`	`return InitError(_("Prune mode is incompatible with -coinstatsindex."));`
	`861`	`+ if (args.GetBoolArg("-reindex-chainstate", false)) {`
	`862`	`+ return InitError(_("Prune mode is incompatible with -reindex-chainstate. Use full -reindex instead."));`
	`863`	`+ }`
`862`	`864`	`}`
`863`	`865`
`864`	`866`	`// If -forcednsseed is set to true, ensure -dnsseed has not been set to false`