wallet: remove unused methods

furszy · furszy · commit 8a5583131ce7 · 2023-03-08T10:32:30.000-03:00
CWallet::DummySignTx, OutputGroupTypeMap::find
diff --git a/src/wallet/coinselection.cpp b/src/wallet/coinselection.cpp
@@ -387,13 +387,6 @@ void OutputGroupTypeMap::Push(const OutputGroup& group, OutputType type, bool in
     }
 }
 
-std::optional<Groups> OutputGroupTypeMap::Find(OutputType type)
-{
-    auto it_by_type = groups_by_type.find(type);
-    if (it_by_type == groups_by_type.end()) return std::nullopt;
-    return it_by_type->second;
-}
-
 CAmount GetSelectionWaste(const std::set<std::shared_ptr<COutput>>& inputs, CAmount change_cost, CAmount target, bool use_effective_value)
 {
     // This function should not be called with empty inputs as that would mean the selection failed
diff --git a/src/wallet/coinselection.h b/src/wallet/coinselection.h
@@ -263,8 +263,6 @@ struct OutputGroupTypeMap
     // Based on the insert flag; appends group to the 'mixed_group' and, if value > 0, to the 'positive_group'.
     // This affects both; the groups filtered by type and the overall groups container.
     void Push(const OutputGroup& group, OutputType type, bool insert_positive, bool insert_mixed);
-    // Retrieves 'Groups' filtered by type
-    std::optional<Groups> Find(OutputType type);
     // Different output types count
     size_t TypesCount() { return groups_by_type.size(); }
 };
diff --git a/src/wallet/wallet.h b/src/wallet/wallet.h
@@ -592,12 +592,6 @@ class CWallet final : public WalletStorage, public interfaces::Chain::Notificati
     bool SubmitTxMemoryPoolAndRelay(CWalletTx& wtx, std::string& err_string, bool relay) const
         EXCLUSIVE_LOCKS_REQUIRED(cs_wallet);
 
-    bool DummySignTx(CMutableTransaction &txNew, const std::set<CTxOut> &txouts, const CCoinControl* coin_control = nullptr) const
-    {
-        std::vector<CTxOut> v_txouts(txouts.size());
-        std::copy(txouts.begin(), txouts.end(), v_txouts.begin());
-        return DummySignTx(txNew, v_txouts, coin_control);
-    }
     bool DummySignTx(CMutableTransaction &txNew, const std::vector<CTxOut> &txouts, const CCoinControl* coin_control = nullptr) const;
 
     bool ImportScripts(const std::set<CScript> scripts, int64_t timestamp) EXCLUSIVE_LOCKS_REQUIRED(cs_wallet);

Original file line number	Diff line number	Diff line change
`@@ -387,13 +387,6 @@ void OutputGroupTypeMap::Push(const OutputGroup& group, OutputType type, bool in`
`387`	`387`	`}`
`388`	`388`	`}`
`389`	`389`
`390`		`-std::optional<Groups> OutputGroupTypeMap::Find(OutputType type)`
`391`		`-{`
`392`		`- auto it_by_type = groups_by_type.find(type);`
`393`		`- if (it_by_type == groups_by_type.end()) return std::nullopt;`
`394`		`- return it_by_type->second;`
`395`		`-}`
`396`		`-`
`397`	`390`	`CAmount GetSelectionWaste(const std::set<std::shared_ptr<COutput>>& inputs, CAmount change_cost, CAmount target, bool use_effective_value)`
`398`	`391`	`{`
`399`	`392`	`// This function should not be called with empty inputs as that would mean the selection failed`