clang-tidy: Add performance-faster-string-find check

hebasto · hebasto · commit 516b75f66ec3 · 2023-03-26T20:17:46.000+01:00
https://clang.llvm.org/extra/clang-tidy/checks/performance/faster-string-find.html
diff --git a/src/.clang-tidy b/src/.clang-tidy
@@ -5,6 +5,7 @@ bugprone-use-after-move,
 misc-unused-using-decls,
 modernize-use-default-member-init,
 modernize-use-nullptr,
+performance-faster-string-find,
 performance-for-range-copy,
 performance-move-const-arg,
 performance-no-automatic-move,
diff --git a/src/rpc/util.cpp b/src/rpc/util.cpp
@@ -732,12 +732,12 @@ UniValue RPCArg::MatchesType(const UniValue& request) const
 
 std::string RPCArg::GetFirstName() const
 {
-    return m_names.substr(0, m_names.find("|"));
+    return m_names.substr(0, m_names.find('|'));
 }
 
 std::string RPCArg::GetName() const
 {
-    CHECK_NONFATAL(std::string::npos == m_names.find("|"));
+    CHECK_NONFATAL(std::string::npos == m_names.find('|'));
     return m_names;
 }
 
diff --git a/src/util/bip32.cpp b/src/util/bip32.cpp
@@ -25,7 +25,7 @@ bool ParseHDKeypath(const std::string& keypath_str, std::vector<uint32_t>& keypa
         }
         // Finds whether it is hardened
         uint32_t path = 0;
-        size_t pos = item.find("'");
+        size_t pos = item.find('\'');
         if (pos != std::string::npos) {
             // The hardened tick can only be in the last index of the string
             if (pos != item.size() - 1) {
diff --git a/src/zmq/zmqpublishnotifier.cpp b/src/zmq/zmqpublishnotifier.cpp
@@ -96,7 +96,7 @@ static bool IsZMQAddressIPV6(const std::string &zmq_address)
 {
     const std::string tcp_prefix = "tcp://";
     const size_t tcp_index = zmq_address.rfind(tcp_prefix);
-    const size_t colon_index = zmq_address.rfind(":");
+    const size_t colon_index = zmq_address.rfind(':');
     if (tcp_index == 0 && colon_index != std::string::npos) {
         const std::string ip = zmq_address.substr(tcp_prefix.length(), colon_index - tcp_prefix.length());
         CNetAddr addr;

Original file line number	Diff line number	Diff line change
`@@ -732,12 +732,12 @@ UniValue RPCArg::MatchesType(const UniValue& request) const`
`732`	`732`
`733`	`733`	`std::string RPCArg::GetFirstName() const`
`734`	`734`	`{`
`735`		`- return m_names.substr(0, m_names.find("\|"));`
	`735`	`+ return m_names.substr(0, m_names.find('\|'));`
`736`	`736`	`}`
`737`	`737`
`738`	`738`	`std::string RPCArg::GetName() const`
`739`	`739`	`{`
`740`		`- CHECK_NONFATAL(std::string::npos == m_names.find("\|"));`
	`740`	`+ CHECK_NONFATAL(std::string::npos == m_names.find('\|'));`
`741`	`741`	`return m_names;`
`742`	`742`	`}`
`743`	`743`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ bool ParseHDKeypath(const std::string& keypath_str, std::vector<uint32_t>& keypa`
`25`	`25`	`}`
`26`	`26`	`// Finds whether it is hardened`
`27`	`27`	`uint32_t path = 0;`
`28`		`- size_t pos = item.find("'");`
	`28`	`+ size_t pos = item.find('\'');`
`29`	`29`	`if (pos != std::string::npos) {`
`30`	`30`	`// The hardened tick can only be in the last index of the string`
`31`	`31`	`if (pos != item.size() - 1) {`
Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ static bool IsZMQAddressIPV6(const std::string &zmq_address)`
`96`	`96`	`{`
`97`	`97`	`const std::string tcp_prefix = "tcp://";`
`98`	`98`	`const size_t tcp_index = zmq_address.rfind(tcp_prefix);`
`99`		`- const size_t colon_index = zmq_address.rfind(":");`
	`99`	`+ const size_t colon_index = zmq_address.rfind(':');`
`100`	`100`	`if (tcp_index == 0 && colon_index != std::string::npos) {`
`101`	`101`	`const std::string ip = zmq_address.substr(tcp_prefix.length(), colon_index - tcp_prefix.length());`
`102`	`102`	`CNetAddr addr;`