refactor, net: Increase CNode data member encapsulation

hebasto · hebasto · commit 3642b2ed34e6 · 2021-01-10T12:00:46.000+02:00
All protected CNode data members could be private.
diff --git a/src/net.h b/src/net.h
@@ -528,11 +528,6 @@ class CNode
      */
     Network ConnectedThroughNetwork() const;
 
-protected:
-    mapMsgCmdSize mapSendBytesPerMsgCmd GUARDED_BY(cs_vSend);
-    mapMsgCmdSize mapRecvBytesPerMsgCmd GUARDED_BY(cs_vRecv);
-
-public:
     // We selected peer as (compact blocks) high-bandwidth peer (BIP152)
     std::atomic<bool> m_bip152_highbandwidth_to{false};
     // Peer selected us as (compact blocks) high-bandwidth peer (BIP152)
@@ -605,8 +600,6 @@ class CNode
     CNode(const CNode&) = delete;
     CNode& operator=(const CNode&) = delete;
 
-public:
-
     NodeId GetId() const {
         return id;
     }
@@ -657,8 +650,6 @@ class CNode
         nRefCount--;
     }
 
-
-
     void AddAddressKnown(const CAddress& _addr)
     {
         assert(m_addr_known);
@@ -690,7 +681,6 @@ class CNode
         }
     }
 
-
     void AddKnownTx(const uint256& hash)
     {
         if (m_tx_relay != nullptr) {
@@ -760,6 +750,9 @@ class CNode
 
     //! Whether this peer is an inbound onion, e.g. connected via our Tor onion service.
     const bool m_inbound_onion{false};
+
+    mapMsgCmdSize mapSendBytesPerMsgCmd GUARDED_BY(cs_vSend);
+    mapMsgCmdSize mapRecvBytesPerMsgCmd GUARDED_BY(cs_vRecv);
 };
 
 /**
