util: use HAVE_FDATASYNC to determine fdatasync() use

fanquake · fanquake · commit 1d8338d6b714 · 2020-07-28T22:39:56.000+08:00
Rather than just using it on Linux and NetBSD, use `fdatasync()` based on whether it's available. i.e it is available in newer versions of FreeBSD (11.1 and later). This also aligns our code more closely with what is being done in leveldb. Was pointed out by Luke in bitcoin#19430.
diff --git a/src/util/system.cpp b/src/util/system.cpp
@@ -1021,7 +1021,7 @@ bool FileCommit(FILE *file)
         return false;
     }
 #else
-    #if defined(__linux__) || defined(__NetBSD__)
+    #if defined(HAVE_FDATASYNC)
     if (fdatasync(fileno(file)) != 0 && errno != EINVAL) { // Ignore EINVAL for filesystems that don't support sync
         LogPrintf("%s: fdatasync failed: %d\n", __func__, errno);
         return false;

Original file line number	Diff line number	Diff line change
`@@ -1021,7 +1021,7 @@ bool FileCommit(FILE *file)`
`1021`	`1021`	`return false;`
`1022`	`1022`	`}`
`1023`	`1023`	`#else`
`1024`		`- #if defined(__linux__) \|\| defined(__NetBSD__)`
	`1024`	`+ #if defined(HAVE_FDATASYNC)`
`1025`	`1025`	`if (fdatasync(fileno(file)) != 0 && errno != EINVAL) { // Ignore EINVAL for filesystems that don't support sync`
`1026`	`1026`	`LogPrintf("%s: fdatasync failed: %d\n", __func__, errno);`
`1027`	`1027`	`return false;`