refactor: use fold expressions instead of recursive calls in UnserializeMany()

martinus · martinus · commit 1403d181c106 · 2023-08-03T10:31:33.000+02:00
Instead of recursively calling `UnserializeMany` and peeling off one
argument at a time, use a fold expression. This simplifies the code,
makes it most likely faster because it reduces the number of function
calls, and compiles faster because there are fewer template
instantiations.
diff --git a/src/serialize.h b/src/serialize.h
@@ -1045,16 +1045,10 @@ void SerializeMany(Stream& s, const Args&... args)
     (::Serialize(s, args), ...);
 }
 
-template<typename Stream>
-inline void UnserializeMany(Stream& s)
-{
-}
-
-template<typename Stream, typename Arg, typename... Args>
-inline void UnserializeMany(Stream& s, Arg&& arg, Args&&... args)
+template <typename Stream, typename... Args>
+inline void UnserializeMany(Stream& s, Args&&... args)
 {
-    ::Unserialize(s, arg);
-    ::UnserializeMany(s, args...);
+    (::Unserialize(s, args), ...);
 }
 
 template<typename Stream, typename... Args>

Original file line number	Diff line number	Diff line change
`@@ -1045,16 +1045,10 @@ void SerializeMany(Stream& s, const Args&... args)`
`1045`	`1045`	`(::Serialize(s, args), ...);`
`1046`	`1046`	`}`
`1047`	`1047`
`1048`		`-template<typename Stream>`
`1049`		`-inline void UnserializeMany(Stream& s)`
`1050`		`-{`
`1051`		`-}`
`1052`		`-`
`1053`		`-template<typename Stream, typename Arg, typename... Args>`
`1054`		`-inline void UnserializeMany(Stream& s, Arg&& arg, Args&&... args)`
	`1048`	`+template <typename Stream, typename... Args>`
	`1049`	`+inline void UnserializeMany(Stream& s, Args&&... args)`
`1055`	`1050`	`{`
`1056`		`- ::Unserialize(s, arg);`
`1057`		`- ::UnserializeMany(s, args...);`
	`1051`	`+ (::Unserialize(s, args), ...);`
`1058`	`1052`	`}`
`1059`	`1053`
`1060`	`1054`	`template<typename Stream, typename... Args>`