Repository navigation
Fix Traditional Chinese label generator crash - #1728
tankerkiller125 merged 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. Summary by CodeRabbit
WalkthroughThe Traditional Chinese label-generator tips now escape embedded HTML tags correctly. A Vitest test validates that three tips parse with ChangesTraditional Chinese label-generator messages
Estimated code review effort: 1 (Trivial) | ~5 minutes Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to Traditional Chinese users can open the label generator without ICU tag parsing failures while the link and emphasized guidance continue to render as intended. The targeted message parsing coverage supports merge readiness. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Tags now rest inside quoted light Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
What type of PR is this?
Context
The Traditional Chinese label generator cannot open because the first rich-text tip contains unescaped HTML markup that
IntlMessageFormatparses as an invalid ICU tag. Once that parser error is removed, the following bold tip also expects a missing rich-text formatter and fails during formatting.Changes
User impact
Users whose locale is
zh-TWcan open/reports/label-generatorinstead of receiving a 500 error. The Avery link and emphasized guidance continue to render as HTML.Before
After
Which issue(s) this PR fixes:
Fixes #1684
Verification
pnpm exec vitest --run --config ./test/vitest.config.ts locales/zh-TW.test.ts --no-file-parallelism— passes (1 test).pnpm run lint:ciandpnpm run lint:fix— pass.pnpm run build— passes and prerenders the label-generator route.task go:lint— passes with 0 issues.task swag --forceplus TypeScript API generation — pass with no generated diff.zh-TW, and verified the report renders with one functional Avery link.pnpm exec nuxi typecheck --noEmit— still reports the existing type errors present on currentmain; none point to the changed locale or test.