Want to start off by saying love the lib 👍 am a huge fan of snapshot testing and this powers pretty much all of our python integration tests.

I agree around tests being deterministic, but just realistically our api's return db id's and I'd prefer not to mock out the whole db interaction bec it's kind of nice that it's captured by the snapshot test. our tests our deterministic outside of id generation from the db (sometimes things get committed/flushed for a bunch of reasons), so I don't think it necessarily makes sense to be overly dogmatic that a snapshot can't have an id field that's dynamic.

we have a bunch of code that cleans up our api responses to test that id's are returning correct values so that we can run them through the snapshot test.

it would be really nice if there was someway to handle these situations smoothly and the tests would handle type checking values that are dynamic. so for example it would be great if in the snapshot we could do something like the following:

self.assertMatchSnapshot(res, dynamic=[("id", number)])

where dynamic is a list of tuples specifying the dynamic ids, and the expected instance that should be asserted to match. I understand if this is a bit beyond the scope of the lib, bec of all of the different workflow that can happen around dynamic fields. That being said it could get pretty hairy to support the various workflows of dynamic json generation - alternatively you could say you only handle simple use cases.

There's a go lib called abide that handles this in a cool manner.

@syrusakbary if we can agree on an appropriate api, I'd be happy to tackle and give back to the lib since it's been super helpful for us.

Please add ignored fields #21

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions