Skip to content

Add types#16

Merged
ChristianMurphy merged 9 commits intosyntax-tree:masterfrom
ChristianMurphy:types/add-typescript-typings
Jul 31, 2019
Merged

Add types#16
ChristianMurphy merged 9 commits intosyntax-tree:masterfrom
ChristianMurphy:types/add-typescript-typings

Conversation

@ChristianMurphy
Copy link
Copy Markdown
Member

@ChristianMurphy ChristianMurphy commented Jul 21, 2019 •
edited
Loading

@ChristianMurphy ChristianMurphy requested a review from a team July 21, 2019 04:42
@ChristianMurphy
Copy link
Copy Markdown
Member Author

ChristianMurphy commented Jul 21, 2019

/cc @Rokt33r

ChristianMurphy
ChristianMurphy commented Jul 21, 2019
View reviewed changes
Comment thread types/index.d.ts Outdated
Rokt33r
Rokt33r reviewed Jul 22, 2019
View reviewed changes
Copy link
Copy Markdown

@Rokt33r Rokt33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other part looks good to me.

Comment thread types/index.d.ts Outdated
ChristianMurphy
ChristianMurphy commented Jul 26, 2019
View reviewed changes
Comment thread package.json Outdated
@wooorm

This comment has been minimized.

Sign in to view
@ChristianMurphy

This comment has been minimized.

Sign in to view
@wooorm

This comment has been minimized.

Sign in to view
@ChristianMurphy

This comment has been minimized.

Sign in to view
@ChristianMurphy

This comment has been minimized.

Sign in to view
@Rokt33r

This comment has been minimized.

Sign in to view
@ChristianMurphy ChristianMurphy mentioned this pull request Jul 30, 2019
Merged
@ChristianMurphy

This comment has been minimized.

Sign in to view
@wooorm

This comment has been minimized.

Sign in to view
@ChristianMurphy

This comment has been minimized.

Sign in to view
ChristianMurphy added a commit to syntax-tree/unist-util-visit-parents that referenced this pull request Jul 30, 2019
@ChristianMurphy
types: add typings for unist-util-visit-parents (#7)
61d3786 
related to: syntax-tree/unist-util-visit#16
ChristianMurphy
ChristianMurphy commented Jul 30, 2019
View reviewed changes
Comment thread package.json Outdated
@ChristianMurphy

This comment has been minimized.

Sign in to view
wooorm pushed a commit to syntax-tree/unist-util-visit-parents that referenced this pull request Jul 31, 2019
@ChristianMurphy @wooorm
Add typings
84c53bc 
Related to: syntax-tree/unist-util-visit#16.

Closes GH-7.

Reviewed-by: Junyoung Choi <[email protected]>
Reviewed-by: Titus Wormer <[email protected]>
@wooorm
Copy link
Copy Markdown
Member

wooorm commented Jul 31, 2019

[email protected] is out!

@ChristianMurphy
Copy link
Copy Markdown
Member Author

ChristianMurphy commented Jul 31, 2019

Thanks @wooorm 🙇
Updated to use the official release.

@ChristianMurphy ChristianMurphy merged commit cdc04ae into syntax-tree:master Jul 31, 2019
@ChristianMurphy ChristianMurphy deleted the types/add-typescript-typings branch July 31, 2019 15:41
@wooorm wooorm changed the title types: add typings and type tests for unist-util-visit Add types Aug 12, 2019
@wooorm wooorm added the 💪 phase/solved Post is done label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wooorm wooorm wooorm approved these changes

+1 more reviewer

@Rokt33r Rokt33r Rokt33r approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

☂️ area/types This affects typings 💪 phase/solved Post is done 🧑 semver/major This is a change 🦋 type/enhancement This is great to have

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add types

3 participants

@ChristianMurphy @wooorm @Rokt33r