Prefer reference over identifier when reverting an unresolved reference. #22
+28
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 8, 2018
wooorm
added a commit
to syntax-tree/mdast
that referenced
this pull request
Aug 31, 2018
This change adds support for a new optional field on the association mixin, used by `definition`, `footnoteDefinition`, the `Reference` mixin (in turn used by `linkReference`, `imageReference`, and `footnoteReference`). The value of the `label` field must, when present, hold the non-normalised value of the `identifier` field. This allows references that are not association with definitions to be represented correctly as raw text again. Closes GH-23. Related to syntax-tree/mdast-util-to-hast#20 Related to syntax-tree/mdast-util-to-hast#21 Related to syntax-tree/mdast-util-to-hast#22 Related to remarkjs/remark#346
|
Ping @wooorm |
Contributor
Author
wooorm
added a commit
to remarkjs/remark
that referenced
this pull request
Oct 14, 2018
* remark-parse: add label to definition, footnote definition, link reference, image reference, footnote reference * remark-stringify: use full reference if no type is set Related to syntax-tree/mdast#23. Related to syntax-tree/mdast-util-to-hast#22. Supersedes GH-346. Closes GH-363. Reviewed-by: Christian Murphy <[email protected]> Co-authored-by: Sam Ruby <[email protected]>
wooorm
added a commit
that referenced
this pull request
Nov 11, 2018
Closes GH-22. Related to GH-20. Related to syntax-tree/mdast#23. Related to remarkjs/remark#346. Co-authored-by: Sam Ruby <[email protected]>
wooorm
added
⛵️ status/released
🐛 type/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.