Sync with updated fork PR for on top of origin #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore(docs): fix test badge
Co-authored-by: Joel Arvidsson <[email protected]>
…blador#669) * refactor: remove duplicated code and add hasCredentialsWithSecClass * fix: ios build
* fix: improve strongbox detection * ci: add gradle build workflow * ci: change java to 17 * chore: cleanup
* test: add new e2e test scenarios * ci: fix e2e workflow * ci: fix workflow * ci: move enrollFingerprint to workflow * ci: fix workflow * ci: fix worflow sleep command * typo: sleep command
…PublicKey()' on a null object reference" (oblador#672)
# Conflicts: # KeychainExample/android/build.gradle # README.md # android/build.gradle # android/src/main/java/com/oblador/keychain/KeychainModule.java # android/src/test/java/com/oblador/keychain/KeychainModuleTests.java # build.gradle.kts
Reimplement data store refactoring on version 9.1.0
# Conflicts: # README.md # android/build.gradle # android/src/main/java/com/oblador/keychain/DataStorePrefsStorage.kt # android/src/main/java/com/oblador/keychain/KeychainModule.java # android/src/test/java/com/oblador/keychain/KeychainModuleTests.java # build.gradle.kts # package.json # typings/react-native-keychain.d.ts
Collaborator
Author
|
@limpbrains Please have a look if this works correctly, I've did what I thought needed to align it with your former changes so it's importable with I will check myself as well. This PR aligns our internal fork with the updates I added to my PR for the original library |
Collaborator
Author
|
Worked after I fixed a merge issue in a7edfe4 🎉 |
|
Tested LGTM! |
limpbrains
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes synonymdev/bitkit#2332
Fixes synonymdev/bitkit#1916
Merge latest changes from updated PR which was replayed on top of the latest version of the original library, i.e.
1.9.0SharedPreferenceswithDataStorePreferences oblador/react-native-keychain#629Additional fixes were added:
coroutineScopeto fix hot-reloading in React Native developmentChanges
It may seem a lot but actual changes from our side, needing review are:
Tests I did