Rename package to @synonymdev/react-native-keychain to publish it to npm #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@ovitrif please take a look |
Collaborator
|
@limpbrains all good |
Author
|
please approve and merge, I have no rights |
Collaborator
|
@limpbrains Did you also merge/update with |
ovitrif
approved these changes
Aug 26, 2024
Collaborator
|
Approved but it seems I also don't have rights lol, need admin rights from @BitcoinErrorLog |
Author
I did not, just used your branch |
Collaborator
|
@limpbrains PR is now merged, Perhaps not a good idea, we should rather sync it with the stable version of the root repo. |
ovitrif
added a commit
that referenced
this pull request
Nov 5, 2024
Reimplement data store refactoring on version 9.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to publish this package to npm.
So I'm renaming it and also I think current master should reflect the state of it in npm, so I'm adding all the patches by @ovitrif