fix: stop beignet wallet before replace/wipe it #2385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
pwltr
requested changes
Dec 9, 2024
Comment on lines
+34
to
+39
| // stop onchain wallet if it exists | ||
| try { | ||
| const wallet = getOnChainWallet(); | ||
| await wallet.stop(); | ||
| } catch (e) {} | ||
|
|
Collaborator
There was a problem hiding this comment.
We can expect the wallet to exist at this point, so it should be able to be stopped. If it does fail we should probably propagate and return the error. Especially if we're going to remove the restart in the future.
Suggested change
| // stop onchain wallet if it exists | |
| try { | |
| const wallet = getOnChainWallet(); | |
| await wallet.stop(); | |
| } catch (e) {} | |
| // stop onchain wallet if it exists | |
| const wallet = getOnChainWallet(); | |
| await wallet.stop(); | |
Contributor
Author
There was a problem hiding this comment.
We run wipeApp during Onboard/TermsOfUse, at this point wallet does not exists
Collaborator
There was a problem hiding this comment.
Right ok let's leave it for now. If we're going to remove the restart later we should probably return the error outside the onboarding though.
pwltr
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should prevent wallet instance to write any data to the redux or call any onMessage callback after it has been stoped.
Maybe we can stop restarting RN after this
Linked Issues/Tasks
Type of change
Bug fix
Tests
No test