Skip to content

Conversation

@pwltr
Copy link
Collaborator

@pwltr pwltr commented Sep 12, 2024

Description

Adds a patch to remove usage of StrongBox secure element on Android.

Although StrongBox is a little slower and resource constrained (meaning that it supports fewer concurrent operations) compared to TEE, StrongBox provides better security guarantees against physical and side-channel attacks. If you want to prioritize higher security guarantees over app resource efficiency, we recommend using StrongBox on the devices where it is available. Wherever StrongBox isn't available, your app can always fall back to TEE to store key materials.

See https://synonymworkspace.slack.com/archives/C01H106JRQB/p1725562106199429

Linked Issues/Tasks

Closes #2014

@socket-security
Copy link

socket-security bot commented Sep 12, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Critical CVE npm/[email protected] ⚠︎

View full report↗︎

Next steps

What is a critical CVE?

Contains a Critical Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Copy link
Contributor

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (looks good to me) 👏

@pwltr pwltr self-assigned this Sep 12, 2024
@socket-security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/[email protected] unsafe 0 135 kB nicolo-ribaudo
npm/@eslint-community/[email protected] None 0 432 kB eslint-community-bot
npm/@nicolo-ribaudo/[email protected] None 0 1.66 kB nicolo-ribaudo
npm/@protobufjs/[email protected] None 0 9.05 kB dcode
npm/@protobufjs/[email protected] None 0 9.22 kB dcode
npm/@protobufjs/[email protected] None 0 9.14 kB dcode
npm/@protobufjs/[email protected] None 0 7.75 kB dcode
npm/@protobufjs/[email protected] network 0 8.76 kB dcode
npm/@protobufjs/[email protected] None 0 27 kB dcode
npm/@protobufjs/[email protected] None 0 4.29 kB dcode
npm/@protobufjs/[email protected] None 0 7.77 kB dcode
npm/@protobufjs/[email protected] None 0 6.25 kB dcode
npm/@protobufjs/[email protected] None 0 23.5 kB dcode
npm/@react-native/[email protected] None 0 18.3 kB react-native-bot
npm/@react-native/[email protected] None 0 6.5 kB react-native-bot
npm/@types/[email protected] None 0 31.7 kB types
npm/@types/[email protected] None 0 13.3 kB types
npm/@types/[email protected] None 0 23.2 kB types
npm/@typescript-eslint/[email protected] None 0 2.73 MB jameshenry
npm/@typescript-eslint/[email protected] None 0 18 kB jameshenry
npm/@typescript-eslint/[email protected] None 0 613 kB jameshenry
npm/@typescript-eslint/[email protected] None 0 110 kB jameshenry
npm/@typescript-eslint/[email protected] None 0 156 kB jameshenry
npm/@typescript-eslint/[email protected] None 0 577 kB jameshenry
npm/@typescript-eslint/[email protected] None 0 332 kB jameshenry
npm/@typescript-eslint/[email protected] None 0 19.4 kB jameshenry
npm/[email protected] None 0 8.05 kB ljharb
npm/[email protected] None 0 25.4 kB ljharb
npm/[email protected] None 0 18.8 kB ljharb
npm/[email protected] None 0 7.23 kB ljharb
npm/[email protected] None 0 12.5 kB ljharb
npm/[email protected] None 0 106 kB eslint
npm/[email protected] None 0 2.02 MB ljharb
npm/[email protected] None 0 155 kB ljharb
npm/[email protected] None 0 9.49 kB ljharb
npm/[email protected] None 0 19.9 kB lydell
npm/[email protected] None 0 41.8 kB mysticatea
npm/[email protected] None 0 512 kB brianzchen
npm/[email protected] filesystem 0 325 kB simenb
npm/[email protected] environment 0 118 kB gnoff
npm/[email protected] None 0 1.87 kB satya164
npm/[email protected] None 0 52.7 kB tomhastjarjanto
npm/[email protected] filesystem 0 795 kB ljharb
npm/[email protected] None 0 78.4 kB eslintbot
npm/[email protected] None 0 24.7 kB eslintbot
npm/[email protected] None 0 22.4 kB ljharb
npm/[email protected] None 0 820 kB dibenede
npm/[email protected] None 0 9.31 kB ljharb
npm/[email protected] None 0 10.8 kB ljharb
npm/[email protected] None 0 51.2 kB kael
npm/[email protected] None 0 20.1 kB ljharb
npm/[email protected] None 0 11.9 kB ljharb
npm/[email protected] None 0 11.9 kB ljharb
npm/[email protected] None 0 177 kB dcode
npm/[email protected] None 0 1.17 MB ljharb
npm/[email protected] None 0 31.4 kB ljharb
npm/[email protected] None 0 15.6 kB ljharb
npm/[email protected] None 0 16.1 kB ljharb
npm/[email protected] None 0 30.9 kB ljharb
npm/[email protected] filesystem, network 0 2.74 MB google-wombot
npm/[email protected] None 0 39 kB ljharb
npm/[email protected] None 0 10.1 kB ljharb
npm/[email protected] None 0 10.1 kB nwoltman
npm/[email protected] None 0 36.6 kB ljharb

🚮 Removed packages: npm/@eslint/[email protected], npm/@eslint/[email protected], npm/@humanwhocodes/[email protected], npm/@humanwhocodes/[email protected], npm/@humanwhocodes/[email protected], npm/@trysound/[email protected], npm/@types/[email protected], npm/@ungap/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@pwltr pwltr merged commit c460244 into master Sep 12, 2024
@pwltr pwltr deleted the chore/patches branch September 12, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android startup time is slow

3 participants