Skip to content

Update build instructions #1842

@basantagoswami

Description

@basantagoswami

Related to #1720

The build instructions for your app are not up to date. I am building it as part of walletscrutiny.com 's review and was able to build it from source. Working on a script and dockerfile (see this PR) to make it easy for anyone to build it from source.

Here is what is missing or outdated in BUILD.md:

  • It mentions that the node version is defined in .nvmrc so you should do nvm use to switch the version. But it is actually defined in .node_version, so you will have to do "nvm use cat .node_version".

  • While trying to build one might get an error like this one

error src/constants/env.ts: /home/.../bitkit/src/constants/env.ts: "BACKUPS_SERVER_SLASHTAG" is not defined in .env
  1 | import {
> 2 | 	BACKUPS_SERVER_SLASHTAG,
    | 	^^^^^^^^^^^^^^^^^^^^^^^
  3 | 	BACKUPS_SHARED_SECRET,
  4 | 	BACKUPS_SERVER_HOST,
  5 | 	BACKUPS_SERVER_PUBKEY,.
SyntaxError: /home/...bitkit/src/constants/env.ts: "BACKUPS_SERVER_SLASHTAG" is not defined in .env
  1 | import {
> 2 | 	BACKUPS_SERVER_SLASHTAG,
    | 	^^^^^^^^^^^^^^^^^^^^^^^
  3 | 	BACKUPS_SHARED_SECRET,
  4 | 	BACKUPS_SERVER_HOST,
  5 | 	BACKUPS_SERVER_PUBKEY,
    at File.buildCodeFrameError 

That is because the .env file is missing. That needs to be created manually. postinstall.js has these lines:

const devEnvFile = './.env.development';
const createDevEnvFile = 'cp .env.development.template .env.development';

Which creates .env.development instead of .env

  • One might also face this error
FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':nodejs-mobile-react-native'.
> SDK location not found. Define a valid SDK location with an ANDROID_HOME environment variable or by setting the sdk.dir path in your project's local properties file at '/home/.../bitkit/android/local.properties'.

If you do, then you'd have to create a file called local.properties inside of android and add the path to your Android SDK. For example, in Ubuntu it might be something like sdk.dir = /home/username/Android/Sdk.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestfeature requestA user has an idea for the app

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions