Skip to content

[Bug]: No constraints or retry attempt when failing to obtain price data for conversion resulting in error when interacting with Blocktank #1833

@catch-21

Description

@catch-21

Describe the bug

If Bitkit starts without being able to retrieve price data (has happened to me a few timesunder normal conditions) and it doesn't have past data to use then it displays a dash for the dollar value (see first screenshot). From then on it does not attempt to fix this state even if network conditions are good. As a result, there is no price data for creating a LN channel (see second screenshot).

It would be good to prevent access to any action that requires live price data on the client side.
It would be good to retry obtaining price data if it has been unsuccessful.

Reproduce

  1. With no network (aeroplane mode)
  2. With a new instance of Bitkit
  3. Create a new wallet
  4. Allow network access (disable aeroplane mode)
  5. Tap the 0 bitcoin balance to display dollar
  6. Observe a dash for dollar price instead of 0 (this is probably an ok representation but there are no attempts to update live price data, even with a manual pull-down to refresh)
  7. Tap Receive at the bottom
  8. Tap Receive on Spending Balance
  9. Input valid amount and Continue
  10. Observe 'Undefined' fiat amount in description
  11. Tap Continue
  12. Observe CJIT Error and no progression to create invoice

Screenshots / Recording

Dollar value displays with a dash when there is no price conversion info

Attempting to create CJIT channel displays 'undefined' and produces error

Operating system

Android 13 TKQ1.220829.002

Bitkit version

d710a89

Log output

No response

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingtriageThis issue needs to be looked over by the team

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions