Fixing manifest paths (by temporarily embedding webpack-manifest-plugin fix)#921
Conversation
|
Works great on mac, can't test on windows |
|
Thanks @shellscape for keeping an eye on that ;). I did include it in the new Btw, this embedding I hope is temporary, at best :). I want to get the fix out to our users ASAP because I don't want users to start relying on the new incorrect paths... only for us to change them back later. |
weaverryan
force-pushed
the
try-manifest-fix
branch
4 times, most recently
from
d3313e0 to
2552104
Compare
weaverryan
changed the title
|
This is now ready to go. We may never merge it - it depends on shellscape/webpack-manifest-plugin#249 - I'd like to merge and tag a fix ASAP for people. We could always remove this "embedded" plugin easily and re-add the real one. Cheers! |
weaverryan
force-pushed
the
try-manifest-fix
branch
4 times, most recently
from
19e3bd9 to
6ae04be
Compare
|
I've fully embedded the fix from shellscape/webpack-manifest-plugin#249 I'm confident that I now have the problem solved correctly there. I'd like to get this fix to our users, so I'm planning to merge this PR and temporarily embed the plugin so we can get it released :). Cheers! |
weaverryan
force-pushed
the
try-manifest-fix
branch
from
78f0865 to
b81428d
Compare
…previously embedded in #921 (Kocal) This PR was merged into the main branch. Discussion ---------- Re-add `webpack-manifest-plugin` dependency, which was previously embedded in #921 | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes <!-- please update CHANGELOG.md file --> | Deprecations? | no <!-- please update CHANGELOG.md file --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - Features and deprecations must be submitted against the latest branch. - For new features, provide some code snippets to help understand usage. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility. --> While working on #1381, I noticed that `lib/webpack-manifest-plugin/` was https://github.com/shellscape/webpack-manifest-plugin embedded with fix shellscape/webpack-manifest-plugin#249 The package was embedded because it was possible for the upstream PR to never be merged, but it has been merged and released. We should not have any BCs from https://github.com/shellscape/webpack-manifest-plugin/releases Commits ------- d5d6b7b Re-add webpack-manifest-plugin as a dependency
2 participants
This temporarily embeds shellscape/webpack-manifest-plugin#249, which fixes #907 and also a comment on #914 (comment)
To test this:
Please let me know if this does or doesn't fix your
manifest.jsonfile. I'm also interested in hearing from Windows users, as the fix requires some "path" manipulation.Thanks!