Remove unmaintained file-loader dependency#1398
Merged
Kocal merged 1 commit intosymfony:mainfrom Mar 11, 2026
Merged
Conversation
Kocal
force-pushed
the
webpack-encore-1396
branch
from
0aeab24 to
17020ea
Compare
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated file-loader dependency and updates Encore.copyFiles() to emit copied assets via a custom webpack loader using webpack’s native emission APIs.
Changes:
- Drop
file-loaderfrom dependencies and related feature/package checks. - Rework
copy-files-loaderto compute hashes and emit files viathis.emitFile(), including a new template interpolator for supported placeholders. - Update docs/tests/changelog for the migration, including documenting the BC break for
[N]placeholders.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
package.json |
Removes file-loader from dev + peer dependencies and metadata. |
yarn.lock |
Removes file-loader lock entries and adjusts related transitive deps. |
lib/features.js |
Removes the copy_files feature package requirement for file-loader. |
lib/config-generator.js |
Stops enforcing file-loader; passes filename to the custom copy loader. |
lib/webpack/copy-files-loader.js |
Replaces file-loader usage with emitFile() and placeholder interpolation. |
test/functional.js |
Removes functional coverage for legacy [N] capture-group placeholder behavior. |
index.js |
Updates copyFiles() placeholder documentation. |
CHANGELOG.md |
Notes file-loader removal and documents BC break for [N] placeholders. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Kocal
changed the title
Kocal
force-pushed
the
webpack-encore-1396
branch
from
c819f8f to
1200947
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the deprecated file-loader dependency in favor of webpack's Asset Modules.
This loader was previously used in
Encore.copyFiles().