Replace assets-webpack-plugin dependency by an internal plugin, to generate entrypoints.json file#1342
Merged
Kocal merged 1 commit intosymfony:mainfrom Sep 20, 2024
Merged
Conversation
Kocal
force-pushed
the
drop-assets-webpack-plugin
branch
from
42d8e8d to
e3dc0f0
Compare
Kocal
commented
Sep 17, 2024
Comment on lines
+70
to
+77
| // We don't want to include hot-update files in the manifest | ||
| if (asset.name.includes('.hot-update.')) { | ||
| continue; | ||
| } |
Member
Author
There was a problem hiding this comment.
When you update a file while the dev-server is running, an .hot-update. file can be emitted, but we don't want to add it in the manifest.
Kocal
force-pushed
the
drop-assets-webpack-plugin
branch
from
e3dc0f0 to
8b7a463
Compare
stof
reviewed
Sep 19, 2024
…generate `entrypoints.json` file
Kocal
force-pushed
the
drop-assets-webpack-plugin
branch
from
8b7a463 to
0529865
Compare
stof
approved these changes
Sep 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the https://github.com/ztoben/assets-webpack-plugin dependency with an internal plugin, this allows us:
entrypoints.jsonfor the WebpackEncoreBundle)integrityoptions of https://github.com/ztoben/assets-webpack-pluginThings done in this PR:
Things not done in this PR: