Fix compat with configuring the devserver server as a string#1327
Merged
stof merged 1 commit intosymfony:mainfrom Sep 5, 2024
Merged
Fix compat with configuring the devserver server as a string#1327stof merged 1 commit intosymfony:mainfrom
stof merged 1 commit intosymfony:mainfrom
Conversation
webpack-dev-server supports providing a string when only the type needs to be configured. Our code checking the type to detect the usage of `https` was not properly handling such configuration.
Member
Author
|
This has been detected by the typescript type checker as it now knows the type of |
Kocal
approved these changes
Sep 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
webpack-dev-server supports providing a string when only the type needs to be configured. Our code checking the type to detect the usage of
httpswas not properly handling such configuration.