Changing to support the "server" options object for webpack-dev-server#1125
Merged
Merged
Conversation
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
May 31, 2022
…n (weaverryan) This PR was merged into the 5.4 branch. Discussion ---------- [Encore] Changing dev-server to use the new server option See: symfony/webpack-encore#1125 But it is NOT dependent on that PR. These changes are already "good change" and do not require changes to Encore. Commits ------- 0029c27 [Encore] Changing dev-server to use the new server option
stof
approved these changes
Jul 6, 2022
weaverryan
force-pushed
the
dev-server-server-option
branch
from
cad7b26 to
3bdbe37
Compare
weaverryan
force-pushed
the
dev-server-server-option
branch
from
e787894 to
e0fb0ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #1118 and solves #1119.
The new
serverobject has existed sincewebpack-dev-server4.4 webpack/webpack-dev-server#3940, and we already require 4.8.Support for the old
httpskept for now (with deprecations) to help people migrate.