Repository navigation
[LiveComponent] Fix (de)hydration of DTO collections containing a null item - #4194
Merged
Merged
Conversation
Kocal
force-pushed
the
fix/livecollection-null-item
branch
from
November 3, 2026 19:50
3fcbc78 to
52e32d6
Compare
Kocal
approved these changes
Nov 3, 2026
Member
|
Thank you @0xABCD01. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a LiveProp holds DTO objects in an array and one item is
null, dehydrating the component throws:That
nullitem is the normal state afterLiveCollectionTrait::addCollectionItem()adds a row whose form entry has not been filled in yet, so adding a row to a DTO-backedLiveCollectionTypebreaks the component as soon as the collection already holds at least one record.LiveComponentHydrator::dehydrateValue()rejected every item that did not match the collection's object type.hydrateValue()had the mirror problem: it passednullitems intohydrateObjectValue(), which cannot hydrate them.This keeps
nullitems asnullin both directions. The added integration test runs aCustomerDetails[]prop holding one filled DTO and onenullitem through a full dehydrate/hydrate round trip.