Remove ComponentAttributeFactory and inject EscaperRuntime directly #2749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
approved these changes
May 19, 2025
Member
Kocal
left a comment
Kocal
left a comment
There was a problem hiding this comment.
Very few comments, otherwise it looks nice to me 🤩
carsonbot
added
Status: Reviewed
Kocal
reviewed
May 19, 2025
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
Simplicity FTW 🚀
just minor comments to fix before merge
nicolas-grekas
approved these changes
May 19, 2025
fabpot
approved these changes
May 19, 2025
Member
Author
|
(remaining fabbot failures unrelated / false positives) |
Member
Author
|
LiveComponent dev / 8.4 failures caused by TypeInfo deprecation / unrelated to this PR 
|
fabpot
force-pushed
the
component-attribute-escaper
branch
from
eef2738 to
13755d9
Compare
Member
|
Thank you @smnandre. |
Contributor
|
Is it expected that |
Member
Contributor
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the
ComponentAttributesFactorywith direct usage of theEscaperRuntimefrom TwigInject
EscaperRuntimeinComponentAttributesComponentAttributesFactorywithTwig\EnvironmentandEscaperRuntimeinAddLiveAttributesSubscriber,LiveComponentHydrator, andChildComponentPartialRenderer, ensuringComponentAttributesis instantiated with the necessaryEscaperRuntime.ComponentAttributesconstructor to requireEscaperRuntimedirectly, removing the deprecatedHtmlAttributeEscaperInterface.Remove
ComponentAttributeFactoryComponentAttributesFactoryand its related logic across the codebaseComponentAttributesFactoryDependency Updates
symfony/ux-twig-componentdependency incomposer.jsonto version^2.25.1Documentation Updates
CHANGELOG.mdfor version2.25.1