Skip to content

Conversation

@Kocal
Copy link
Member

@Kocal Kocal commented Aug 17, 2024

Q A
Bug fix? no
New feature? no
Issues Fix #...
License MIT

Fabbot still misses our PHP-CS-Fixer configuration (tracked in #2014) :(

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Aug 17, 2024
@Kocal Kocal requested a review from kbond August 17, 2024 20:21
@kbond
Copy link
Member

kbond commented Aug 20, 2024

Thanks Hugo.

@kbond kbond merged commit 4a80718 into symfony:2.x Aug 20, 2024
@Kocal Kocal deleted the chore/php-cs-fixer branch August 26, 2024 06:23
@Kocal Kocal mentioned this pull request May 31, 2025
Kocal added a commit that referenced this pull request May 31, 2025
This PR was squashed before being merged into the 2.x branch.

Discussion
----------

[CI] Re-add PHP-CS-Fixer

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Docs?         | no <!-- required for new features -->
| Issues        | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT

<!--
Replace this notice by a description of your feature/bugfix.
This will help reviewers and should be a good start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - For new features, provide some code snippets to help understand usage.
 - Features and deprecations must be submitted against branch main.
 - Update/add documentation as required (we can help!)
 - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
 - Never break backward compatibility (see https://symfony.com/bc).
-->

Follow #2802, #2074, #2014 and more.

I feel like Fabbot **only runs on modified files** for a given PR, but sometimes it does not really help (e.g.: if you untouched files contain old references to a deleted class).

This behavior is understandable for symfony/symfony, which contains a tons of code and is super active, but that's not the case symfony/ux, we have very less code and less activity.

**EDIT:** Well, I'm still not sure... PHP-CS-Fixer is showing me fixes for `src/LiveComponent/src/Util/TypeHelper.php`, added in #2778, but it was totally ignored by Fabbot... 😫

So, I suggest to re-add PHP-CS-Fixer run in the CI to ensure all files are correctly CS-fixed.

Commits
-------

1ab48b6 [CI] Re-add PHP-CS-Fixer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Needs Review Needs to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants