Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/ux
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.29.0
Choose a base ref
...
head repository: symfony/ux
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.29.1
Choose a head ref
  • 3 commits
  • 22 files changed
  • 3 contributors

Commits on Aug 8, 2025

  1. [Map] Allows Bridges JavaScript assets to be installed with npm whe… 

    …n using `file:vendor/symfony/ux-*-map/assets`
    @Kocal
    Kocal committed Aug 8, 2025
    Configuration menu
    Copy the full SHA
    1667af7 View commit details
    Browse the repository at this point in the history

  2. Update versions to 2.29.0

    @github-actions
    github-actions[bot] committed Aug 8, 2025
    Configuration menu
    Copy the full SHA
    968f1f1 View commit details
    Browse the repository at this point in the history

  3. bug #2983 [Map] Allows Bridges JavaScript assets to be installed with… 

    … `npm` when using `file:vendor/symfony/ux-*-map/assets` (Kocal)

This PR was merged into the 2.x branch.

Discussion
----------

[Map] Allows Bridges JavaScript assets to be installed with `npm` when using `file:vendor/symfony/ux-*-map/assets`

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Docs?         | no <!-- required for new features -->
| Issues        | Fix #2951, #2737 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT

<!--
Replace this notice by a description of your feature/bugfix.
This will help reviewers and should be a good start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - For new features, provide some code snippets to help understand usage.
 - Features and deprecations must be submitted against branch main.
 - Update/add documentation as required (we can help!)
 - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
 - Never break backward compatibility (see https://symfony.com/bc).
-->

Alternative to #2982.

Moving the `"`@symfony`/ux-map": "workspace:*"` requirements **outside the package.json** allows the Bridges JavaScript assets to be installed with `npm` when ``@symfony`/ux-leaflet-map` (or ``@symfony`/ux-google-map`) is using constraint version `file:vendor/symfony/ux-leaflet-map/assets` (or `file:vendor/symfony/ux-google-map/assets`) in the user application.

This is possible to this super feature from pnpm: [packageExtensions](https://pnpm.io/settings#packageextensions), which allows to override some part of package definitions in file `pnpm-workspace.yaml`:
- this file is read by pnpm and understand that ``@symfony`/ux-map` is a dependency of ``@symfony`/ux-leaflet-map` and ``@symfony`/ux-google-map` 🎉
- this file is totally unknown to npm, no `workspace:*` anymore in any `package.json` 🎉

It is not possible to defines `packageExtensions.devDependencies`, so I used `packageExtensions.dependencies` instead but that's fine. ``@symfony`/ux-map` is not referenced in any `package.json` when running `pnpm pack` in `src/Bridge/*/assets`.

Commits
-------

1667af7 [Map] Allows Bridges JavaScript assets to be installed with `npm` when using `file:vendor/symfony/ux-*-map/assets`
    @kbond
    kbond committed Aug 8, 2025
    Configuration menu
    Copy the full SHA
    d1c9b2b View commit details
    Browse the repository at this point in the history
Loading