Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/ux
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.28.1
Choose a base ref
...
head repository: symfony/ux
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.28.2
Choose a head ref
  • 13 commits
  • 215 files changed
  • 5 contributors

Commits on Jul 29, 2025

  1. Configuration menu
    Copy the full SHA
    a9ea07d View commit details
    Browse the repository at this point in the history
  2. minor #2953 [CI] Rework app-tests job to use npm as user's packag…

    …es manager (Kocal)
    
    This PR was merged into the 2.x branch.
    
    Discussion
    ----------
    
    [CI] Rework `app-tests` job to use `npm` as user's packages manager
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | Docs?         | no <!-- required for new features -->
    | Issues        | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
    | License       | MIT
    
    Following #2952, this way we ensure our packages will always be installable with `npm` (related to #2951)
    
    Commits
    -------
    
    a9ea07d [CI] Rework app-tests job to use npm as user's packages manager
    Kocal committed Jul 29, 2025
    Configuration menu
    Copy the full SHA
    b4c510d View commit details
    Browse the repository at this point in the history
  3. Update versions to 2.28.1

    Kocal committed Jul 29, 2025
    Configuration menu
    Copy the full SHA
    02b8005 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4061a42 View commit details
    Browse the repository at this point in the history
  5. bug #2954 [CI] Fix npm releases with pnpm (Kocal)

    This PR was merged into the 2.x branch.
    
    Discussion
    ----------
    
    [CI] Fix npm releases with pnpm
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | Docs?         | no <!-- required for new features -->
    | Issues        | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
    | License       | MIT
    
    Given https://docs.npmjs.com/using-private-packages-in-a-ci-cd-workflow, https://pnpm.io/using-changesets#add-a-publish-script, or pnpm/pnpm#3141
    
    It should works better now.
    
    ⚠️ no need to release a 2.28.2 right now, I already manually published packages on npm for 2.28.1 version
    
    Commits
    -------
    
    4061a42 [CI] Fix npm releases with pnpm
    Kocal committed Jul 29, 2025
    Configuration menu
    Copy the full SHA
    b486ca8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    23aa491 View commit details
    Browse the repository at this point in the history
  7. minor #2955 [CI] Add Fabbot as a GitHub Actions (Kocal)

    This PR was squashed before being merged into the 2.x branch.
    
    Discussion
    ----------
    
    [CI] Add Fabbot as a GitHub Actions
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | Docs?         | no <!-- required for new features -->
    | Issues        | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
    | License       | MIT
    
    <!--
    Replace this notice by a description of your feature/bugfix.
    This will help reviewers and should be a good start for the documentation.
    
    Additionally (see https://symfony.com/releases):
     - Always add tests and ensure they pass.
     - For new features, provide some code snippets to help understand usage.
     - Features and deprecations must be submitted against branch main.
     - Update/add documentation as required (we can help!)
     - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
     - Never break backward compatibility (see https://symfony.com/bc).
    -->
    
    refs:
    - symfony/symfony#61260
    - twigphp/Twig#4671
    - https://github.com/symfony-tools/fabbot
    
    Since the code formatting process if more transparent, maybe we will remove the job `coding-style-php` that manually execute PHP-CS-Fixer (we had many formatting issues in the past)
    
    Commits
    -------
    
    23aa491 [CI] Add Fabbot as a GitHub Actions
    Kocal committed Jul 29, 2025
    Configuration menu
    Copy the full SHA
    0b2b031 View commit details
    Browse the repository at this point in the history
  8. Apply fabbot rules

    nicolas-grekas committed Jul 29, 2025
    Configuration menu
    Copy the full SHA
    7b135d0 View commit details
    Browse the repository at this point in the history
  9. minor #2957 Apply fabbot rules (nicolas-grekas)

    This PR was merged into the 2.x branch.
    
    Discussion
    ----------
    
    Apply fabbot rules
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | Docs?         | no
    | Issues        | -
    | License       | MIT
    
    - no-void to test cases
    - typos
    - tweaks to exception messages
    
    Commits
    -------
    
    7b135d0 Apply fabbot rules
    Kocal committed Jul 29, 2025
    Configuration menu
    Copy the full SHA
    1f90d60 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2025

  1. Configuration menu
    Copy the full SHA
    bdf6270 View commit details
    Browse the repository at this point in the history
  2. bug #2959 [ux-icons] Fix value of xmlns attribute for imported svg ic…

    …ons (roverwolf)
    
    This PR was squashed before being merged into the 2.x branch.
    
    Discussion
    ----------
    
    [ux-icons] Fix value of xmlns attribute for imported svg icons
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | Docs?         | no
    | Issues        | Fix #2958
    | License       | MIT
    
    Change the xmlns attribute to be `http://www.w3.org/2000/svg` for icons imported using `console ux:icons:import` so that the icons will correctly render in browsers and can be viewed by other image tools.
    
    Commits
    -------
    
    bdf6270 [ux-icons] Fix value of xmlns attribute for imported svg icons
    Kocal committed Jul 30, 2025
    Configuration menu
    Copy the full SHA
    43fd7e9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5b8d701 View commit details
    Browse the repository at this point in the history
  4. bug #2961 [LiveComponent] Fix LiveUrlSubscriber throw `MethodNotAllow…

    …ed` (smnandre)
    
    This PR was squashed before being merged into the 2.x branch.
    
    Discussion
    ----------
    
    [LiveComponent] Fix LiveUrlSubscriber throw `MethodNotAllowed`
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | Docs?         | no <!-- required for new features -->
    | Issues        | Fix #2960
    | License       | MIT
    
    > [!WARNING]
    > Not sure this is enough, but If anyone wants to build on it, feel free - wont be around tomorrow.
    
    ---
    
    The new LiveUrlSubscriber calls the Router to match the previous Url.
    
    At that instant, the RoutingContext is most of the time in POST, and so calling router->match($previousUrl) would throw a MethodNotAllowedException
    
    ---
    
    Most recent commit ([Catch MethodNotAllowedException](1da8a7b)) fixes _**this**_ issue ... but I think we have probably other use cases where it would not work.
    
    My previous commit (reverted in the current state) [Force RequestsContext to "GET"](e81aad2) seems a more promising lead.
    
    And the first one (reverted too in current state) [No LiveProps no change](1da8a7b)  was to avoid entirely the generation when no props were extracted from URL... sadly i don't think it's enough to say "no props should now be used in URL".. ?
    
    ---
    
    Thank you `@zacharylund`  for the investigation and `@jmsche` for the perfect reproducer
    
    Commits
    -------
    
    5b8d701 [LiveComponent] Fix LiveUrlSubscriber throw `MethodNotAllowed`
    kbond committed Jul 30, 2025
    Configuration menu
    Copy the full SHA
    6940885 View commit details
    Browse the repository at this point in the history
Loading