Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Aug 16, 2017

The description was not suitable for the given setfacl commands.

@xabbuh
Copy link
Member

xabbuh commented Aug 16, 2017

We recently swapped the calls for good reasons in #7987. I think we should then update the description instead if it doesn't match the example.

Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


  The first ``setfacl`` command sets permissions on the existing files and
folders, while the second one sets permissions for future files and folders.
  The first ``setfacl`` command sets permissions for future files and folder, while the second one sets permissions on the existing files and folders.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you add a line break after the first word crossing the 72th character, this PR would be perfect! :) (if you don't have the time, we can do it during merging).

Update the setfacl description.
@xabbuh
Copy link
Member

xabbuh commented Sep 1, 2017

Thank you @zephyr-thomas.

xabbuh added a commit that referenced this pull request Sep 1, 2017
This PR was submitted for the 3.3 branch but it was merged into the 2.7 branch instead (closes #8290).

Discussion
----------

Swap the two setfacl commands

The description was not suitable for the given setfacl commands.

Commits
-------

b6f9f74 Update the setfacl description.
xabbuh added a commit that referenced this pull request Sep 1, 2017
@xabbuh xabbuh closed this Sep 1, 2017
xabbuh added a commit that referenced this pull request Sep 3, 2017
* 2.7:
  [#8231] fix reStructuredText syntax
  Specified import order of config files
  [#7981] revert some changes
  Update upload_file.rst
  Added a missing redirection
  Update validation_group_service_resolver.rst
  Update redirection_map
  Update button_based_validation.rst
  Delete group_service_resolver.rst
  Create validation_group_service_resolver.rst
  [#8290] fix minor typo
  Update the setfacl description.
  Update associations.rst
  Update proxy_examples.rst
  Fixed logger processor example
xabbuh added a commit that referenced this pull request Sep 3, 2017
* 2.8: (25 commits)
  [#8231] fix reStructuredText syntax
  Specified import order of config files
  [#7981] revert some changes
  Update upload_file.rst
  Added a missing redirection
  Update validation_group_service_resolver.rst
  Update redirection_map
  Update button_based_validation.rst
  Delete group_service_resolver.rst
  Create validation_group_service_resolver.rst
  [#8290] fix minor typo
  Update the setfacl description.
  Update events.rst
  Fixed a minor syntax issue
  Update phpunit_bridge.rst
  First parameter to uniqid must be a string
  fix #8321 minor changes in Serializer Component
  Update filesystem.rst
  Update associations.rst
  Update proxy_examples.rst
  ...
xabbuh added a commit that referenced this pull request Sep 3, 2017
* 3.3: (40 commits)
  [#8273] fix bundle registration code
  [#8273] minor rewording
  Reworded the built-in web server articles for Symfony 3.3
  fix diff code block highlighting
  [#8231] fix reStructuredText syntax
  Specified import order of config files
  [#7981] revert some changes
  Update upload_file.rst
  Update usage.rst
  Update doctrine.rst
  Update usage.rst
  [#8260] add missing redirection map entry
  Delete use_virtuals_forms.rst
  Added a missing redirection
  Update validation_group_service_resolver.rst
  Update redirection_map
  Update button_based_validation.rst
  Delete group_service_resolver.rst
  Create validation_group_service_resolver.rst
  [#8290] fix minor typo
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants