Documented the String component #12440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Works for me, thank you. |
Contributor
|
Great work so far Javier 🙂👍🏻 |
Member
Author
|
The article is now ready for review. The only missing part is the Slugger, which I'll add soon too. Thanks. |
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
That's cool thank you :)
Here are some comments.
This was referenced Oct 9, 2019
javiereguiluz
changed the title
OskarStark
approved these changes
Oct 9, 2019
gharlan
reviewed
Oct 9, 2019
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Oct 11, 2019
…as-grekas) This PR was merged into the 5.0-dev branch. Discussion ---------- [String] add $lastGlue argument to join() methods | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - An idea that came when reviewing symfony/symfony-docs#12440 Commits ------- 714d629 [String] add $lastGlue argument to join() methods
javiereguiluz
force-pushed
the
fix_12376
branch
from
84bd97d to
9d08de4
Compare
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Oct 14, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- [String] wrap(): test and fix | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | symfony/symfony-docs/pull/12440 Commits ------- 015b81a [String] wrap(): test and fix
symfony-splitter
pushed a commit
to symfony/string
that referenced
this pull request
Oct 14, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- [String] wrap(): test and fix | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | symfony/symfony-docs/pull/12440 Commits ------- 015b81a2f5 [String] wrap(): test and fix
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Oct 14, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- [String] bytesAt() and codePointsAt() | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #33923 | License | MIT | Doc PR | symfony/symfony-docs/pull/12440 Commits ------- f8d2faa [String] bytesAt() and codePointsAt()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12376 and #12404. This is an early WIP to test if this is correct.
@nicolas-grekas the full API is very long because there are a ton of methods ... so I thought about grouping them by "topic". Would you agree with that?
Thanks!