Skip to content

[Routing][XML Loader] Add a possibility to set a default value to null #7581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aitboudad wants to merge 1 commit into from
Closed

[Routing][XML Loader] Add a possibility to set a default value to null #7581

aitboudad wants to merge 1 commit into from

Conversation

@aitboudad
Copy link
Contributor

@aitboudad aitboudad commented Apr 6, 2013

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #7335
License MIT

Example:

<route id="acme_user_show" pattern="/{id}">
    <default key="_controller">AcmeUserBundle:User:show</default>
    <default key="id" xsi:nil="true" />
    <requirement key="id">\d+</requirement>
</route>

@fabpot
Copy link
Member

fabpot commented Apr 9, 2013

Can you add some unit tests and open a new PR on 2.1 as this is a bug? Thanks.

@aitboudad aitboudad mentioned this pull request Apr 11, 2013
Merged
@aitboudad aitboudad closed this Apr 11, 2013
@aitboudad aitboudad deleted the ticket_7335 branch April 13, 2013 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aitboudad @fabpot