[Security] Fix UserBadge validation bypass via identifier normalizer
#62487
+38
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
UserBadgeconstructor validates that the identifier is not empty and does not exceedMAX_USERNAME_LENGTH.However, when using
$identifierNormalizer, the normalized identifier is computed lazily ingetUserIdentifier()without validation. This allows normalizers to return invalid values:Related to #51744 and #61183
I targeted
7.3as it introducedidentifierNormalizer, please let me know if I should target8.0or8.1instead.