Skip to content

[DependencyInjection][Routing] extract loadContent() methods into reusable traits #62435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xabbuh wants to merge 1 commit into
base: 8.1
Choose a base branch
from
Open

[DependencyInjection][Routing] extract loadContent() methods into reusable traits #62435

xabbuh wants to merge 1 commit into from

Conversation

@xabbuh
Copy link
Member

@xabbuh xabbuh commented Nov 19, 2025 •
edited
Loading

Q A
Branch? 8.1
Bug fix? no
New feature? no
Deprecations? no
Issues see #62129 (comment)
License MIT

@carsonbot carsonbot added this to the 7.4 milestone Nov 19, 2025
@xabbuh xabbuh mentioned this pull request Nov 19, 2025
Merged
@xabbuh xabbuh changed the title [DependencyInjection][Routing] extract loadContent() methods into traits [DependencyInjection][Routing] extract loadContent() methods into reusable traits Nov 19, 2025
@xabbuh xabbuh force-pushed the pr-62129-load-content branch from a999b82 to 52eda73 Compare November 19, 2025 08:20
@alexandre-daubois
Copy link
Member

alexandre-daubois commented Nov 19, 2025

I assume the answer is "yes" given the PR title: you're just moving code around without adding anything new, right?

@xabbuh
Copy link
Member Author

xabbuh commented Nov 19, 2025

I assume the answer is "yes" given the PR title: you're just moving code around without adding anything new, right?

the three protected methods of the YamlFileLoader from the Routing component have also been deprecated, but apart from that this PR is just moving stuff around to allow us to not use reflection

alexandre-daubois
alexandre-daubois reviewed Nov 19, 2025
View reviewed changes
src/Symfony/Component/Routing/CHANGELOG.md Outdated
7.4
---

* Deprecate the `parseRoute()`, `parseImport()`, and `validate()` methods of the `YamlFileLoader` class without replacements
Copy link
Member

@alexandre-daubois alexandre-daubois Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding recent discussions about deprecation messages (cc @javiereguiluz), shouldn't we suggest something even if there's no replacement? Like recommending another mechanism/entrypoint, something like that.

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Nov 20, 2025

That should target 8.1 IMHO. Also, why deprecate the methods? Better not if there's no particular cost associated.

@xabbuh xabbuh changed the base branch from 7.4 to 8.1 November 21, 2025 19:45
@xabbuh xabbuh force-pushed the pr-62129-load-content branch from 52eda73 to c36e9bd Compare November 21, 2025 19:46
@xabbuh xabbuh modified the milestones: 7.4, 8.1 Nov 21, 2025
@xabbuh xabbuh force-pushed the pr-62129-load-content branch from c36e9bd to ca8d17d Compare November 21, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexandre-daubois alexandre-daubois alexandre-daubois left review comments

Assignees

No one assigned

Labels

DependencyInjection Routing Status: Needs Review

Projects

None yet

Milestone

8.1

Development

Successfully merging this pull request may close these issues.

4 participants

@xabbuh @alexandre-daubois @nicolas-grekas @carsonbot