[Form][Intl] Allow the developer to choose if he want to include/exclude currencies that do not have validity dates. #62225
+23
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Oct 30, 2025
src/Symfony/Component/Intl/Exception/CurrencyValidityException.php
Outdated
Show resolved
Hide resolved
Crovitche-1623
changed the title
nicolas-grekas
added
the
❄️ Feature Freeze
…ude currencies that do not have validity dates.
nicolas-grekas
force-pushed
the
fix/ignore-currencies-wo-availability-date
branch
from
9727c1c to
a6020c7
Compare
Member
|
Thank you @Crovitche-1623. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not really a bugfix but a correction from the feedback of @javiereguiluz. This PR add a parameter named
include_undatedthat allows the user to choose if he wants to include or not the currencies that do not have validity dates available. The advantage from the previous implementation is that the exception is gone.