[Notifier] Add support for confirm option in Slack buttons API
#62039
+72
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Oct 11, 2025
src/Symfony/Component/Notifier/Bridge/Slack/Block/SlackActionsBlock.php
Outdated
Show resolved
Hide resolved
OskarStark
approved these changes
Oct 11, 2025
xabbuh
approved these changes
Oct 11, 2025
Member
xabbuh
left a comment
xabbuh
left a comment
There was a problem hiding this comment.
Is it worth it to expand the readme around this? Or is the feature self-discoverable enough?
Contributor
Author
I'm fine with updating the readme, if needed. I honestly tried to stick to the existing pattern in the codebase. The confirm array has very specific structure that can be described using docblock, however this seems not to be the approach through the code base, so I didnt do it here aswell. Ultimately the usage of this code requires having Slack API doc opened in another tab anyway. At least this is my experience with it If you insist on the readme I'll add it, no problem |
fabpot
approved these changes
Oct 12, 2025
Member
|
Thank you @allflame. |
Zarthus
reviewed
Oct 12, 2025
| 'title' => ['type' => 'plaint_text', 'text' => 'Report a bug'], | ||
| 'text' => ['type' => 'plaint_text', 'text' => 'By proceeding I confirm I\'ve read the guidelines.'], | ||
| 'confirm' => ['type' => 'plaint_text', 'text' => 'Proceed'], | ||
| 'deny' => ['type' => 'plaint_text', 'text' => 'Go back to reading'] |
This was referenced Oct 27, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow sending
confirmoption to the Slack API to allow for the confirm dialog to be triggered upon press of a button in the Slack clients