Skip to content

[Console] skip hidden question tests on Windows #62004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yceruto merged 1 commit into from
Oct 8, 2025
Merged

[Console] skip hidden question tests on Windows #62004

yceruto merged 1 commit into from
Oct 8, 2025

Conversation

@xabbuh
Copy link
Member

@xabbuh xabbuh commented Oct 8, 2025

Q A
Branch? 7.4
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

@xabbuh xabbuh requested a review from chalasr as a code owner October 8, 2025 07:15
@carsonbot carsonbot added this to the 7.4 milestone Oct 8, 2025
@xabbuh xabbuh requested review from yceruto and removed request for chalasr October 8, 2025 07:15
@yceruto
Copy link
Member

yceruto commented Oct 8, 2025

Hi @xabbuh, I did the same here #61978 but for the whole test case. Do you think that's okay, or do you still prefer splitting the test case into two?

@xabbuh
Copy link
Member Author

xabbuh commented Oct 8, 2025

I guess it might be good to still test what we can test on Windows too especially given that CLI stuff is always a bit tricky when it comes to different OS.

@yceruto
Copy link
Member

yceruto commented Oct 8, 2025

Thank you @xabbuh.

@yceruto yceruto merged commit c0177fc into symfony:7.4 Oct 8, 2025
12 checks passed
@xabbuh xabbuh deleted the pr-61748 branch October 8, 2025 08:52
@yceruto yceruto mentioned this pull request Oct 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yceruto yceruto yceruto approved these changes

Assignees

No one assigned

Labels

Console Status: Reviewed

Projects

None yet

Milestone

7.4

Development

Successfully merging this pull request may close these issues.

3 participants

@xabbuh @yceruto @carsonbot