[Workflow] Move the dump command to the component #61933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lyrixx
commented
Oct 2, 2025
lyrixx
commented
| Q | A |
|---|---|
| Branch? | 7.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | yes |
| Issues | |
| License | MIT |
lyrixx
force-pushed
the
workflow-command
branch
from
d2cb5a1 to
25430c8
Compare
stof
reviewed
Oct 2, 2025
lyrixx
force-pushed
the
workflow-command
branch
from
25430c8 to
f7fc52b
Compare
Member
Author
|
Thanks @stof for the review. I addressed your comments |
stof
reviewed
Oct 2, 2025
UPGRADE-7.4.md
Outdated
| --------------- | ||
|
|
||
| * Deprecate `Symfony\Bundle\FrameworkBundle\Console\Application::add()` in favor of `addCommand()` | ||
| * Command `Symfony\Bundle\FrameworkBundle\Command\WorkflowDumpCommand` has been moved to `Symfony\Component\Workflow\Command\WorkflowDumpCommand` |
Member
There was a problem hiding this comment.
Suggested change
| * Command `Symfony\Bundle\FrameworkBundle\Command\WorkflowDumpCommand` has been moved to `Symfony\Component\Workflow\Command\WorkflowDumpCommand` | |
| * Deprecate `Symfony\Bundle\FrameworkBundle\Command\WorkflowDumpCommand` in favor of `Symfony\Component\Workflow\Command\WorkflowDumpCommand` |
Symfony\Bundle\FrameworkBundle\Command\WorkflowDumpCommand still exists for BC reasons.
fabpot
approved these changes
Oct 3, 2025
fabpot
force-pushed
the
workflow-command
branch
from
f7fc52b to
1b017d2
Compare
xabbuh
reviewed
Oct 3, 2025
| * @author Grégoire Pineau <[email protected]> | ||
| * | ||
| * @final | ||
| * @deprecated since Symfony 7.4, use {@see \Symfony\Component\Workflow\Command\WorkflowDumpCommand} instead. |
Member
There was a problem hiding this comment.
The suggested code style change looks legit to me.
Member
There was a problem hiding this comment.
Too late, I've fixed it after the merge.
Member
|
Thank you @lyrixx. |
This was referenced Oct 27, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.