[Config][DependencyInjection][Routing] Deprecate using $this or the internal scope of the loader from PHP config files
#61860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
Member
|
the changelog mentions using the |
Member
Author
|
yeah, I think this is too niche anyway |
nicolas-grekas
requested review from
OskarStark,
chalasr,
dunglas,
jderusse,
kbond,
lyrixx,
welcoMattic,
xabbuh and
yceruto
as code owners
nicolas-grekas
changed the title
$this and its internal scope from PHP config files; use the $loader variable instead
nicolas-grekas
changed the title
$this and its internal scope from PHP config files; use the $loader variable instead$this or the internal scope of the loader from PHP config files
nicolas-grekas
force-pushed
the
di-php-static-loader
branch
from
20ab6a5 to
11fcdb5
Compare
Member
Author
|
PR updated, I figured out a BC layer! |
stof
reviewed
Sep 29, 2025
Member
stof
left a comment
stof
left a comment
There was a problem hiding this comment.
I suggest adding a test covering this BC layer (as the SecurityBundle functional tests have been migrated to stop using this feature)
src/Symfony/Component/Config/Definition/Loader/DefinitionFileLoader.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
force-pushed
the
di-php-static-loader
branch
2 times, most recently
from
05702a1 to
3ab95d2
Compare
Member
Author
|
Tests added |
… internal scope of the loader from PHP config files
nicolas-grekas
force-pushed
the
di-php-static-loader
branch
from
3ab95d2 to
9afb4f4
Compare
This was referenced Oct 27, 2025
Merged
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Dec 4, 2025
…rnal scope from PHP config files (nicolas-grekas) This PR was merged into the 7.4 branch. Discussion ---------- [DependencyInjection] Throw when using `$this` or its internal scope from PHP config files | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | #62547 | License | MIT The BC layer brought by #61860 doesn't work: as described in #62547, the first call to load() has side effects which can break when the second and fallback call is made. I don't see any other way. Well, one would be to operate on a clone, and if that works, rerun with the real container builder. But the overhead is going to be high for everybody. I'm therefor proposing to change this as a BC BREAK. While less than ideal, this happens at compile time, and the fix is trivial and explained in the error message. Commits ------- 7ffcd64 [DependencyInjection] Throw when using `$this` or its internal scope from PHP config files; use the `$loader` variable instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The target of this change is being able to patch the PHP-DSL examples in the documentation without any downsides: