Skip to content

[Intl] Support time in generated data in currencies validity #61859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabpot merged 1 commit into from
Oct 1, 2025
Merged

[Intl] Support time in generated data in currencies validity #61859

fabpot merged 1 commit into from
Oct 1, 2025

Conversation

@Crovitche-1623
Copy link
Contributor

@Crovitche-1623 Crovitche-1623 commented Sep 26, 2025 •
edited
Loading

Q A
Branch? 6.4
Bug fix? no
New feature? yes
Deprecations? no
Issues -
License MIT

@nicolas-grekas

see #61837 (comment)

Note: This PR is a prerequisite of #61837

@carsonbot carsonbot added this to the 6.4 milestone Sep 26, 2025
@Crovitche-1623 Crovitche-1623 mentioned this pull request Sep 26, 2025
Merged
nicolas-grekas
nicolas-grekas reviewed Sep 26, 2025
View reviewed changes
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Sep 26, 2025

Ah, I think we should remove the TZ info, it should be implicit: +00:00 should be removed

stof
stof reviewed Sep 26, 2025
View reviewed changes
Copy link
Member

@stof stof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currencies need to be updated, as it uses \DateTimeImmutable::createFromFormat('Y-m-d'): https://github.com/symfony/symfony/blob/52561f9d9de633b59834f58f47b23b77ad966a62/src/Symfony/Component/Intl/Currencies.php#L228C17-L228C61

note that if you want to omit the +00:00 TZ info, you need to force the UTC timezone when consuming it, to avoid issues for servers using a different default timezone in their php.ini.

@Crovitche-1623
Copy link
Contributor Author

Crovitche-1623 commented Sep 29, 2025 •
edited
Loading

Ah, I think we should remove the TZ info, it should be implicit: +00:00 should be removed

@nicolas-grekas Ok, I'll remove the +00:00 even though I deliberately put it there to avoid any confusion with the source XML files.

@stof The methods that process the meta.php file were added in the 7.4 branch. I'll do the required changes in Currencies in #61837 (also in 7.4) if it's ok for you as it'll be the sole place the data are used

Crovitche-1623 added a commit to Crovitche-1623/symfony that referenced this pull request Sep 29, 2025
@Crovitche-1623
refactor: change the format according to symfony#61859 + force UTC in…
ca603eb 
… declaration as the timezone is missing from the format
@fabpot
Copy link
Member

fabpot commented Oct 1, 2025

Thank you @Crovitche-1623.

@fabpot fabpot merged commit d7186d2 into symfony:6.4 Oct 1, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stof stof stof left review comments

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees

No one assigned

Labels

Feature Intl Status: Reviewed

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

5 participants

@Crovitche-1623 @nicolas-grekas @fabpot @stof @carsonbot