[Config] Config builders should accept booleans for array nodes that can be enabled or disabled #61858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
config-pump
branch
from
78db3dd to
bf1f204
Compare
nicolas-grekas
commented
Sep 26, 2025
| $allowedTypes = $this->allowedTypes ?? $this->normalization->declaredTypes; | ||
| foreach ([$this->trueEquivalent, $this->falseEquivalent] as $equivalent) { | ||
| if (\is_array($equivalent) && $equivalent) { | ||
| $allowedTypes[] = ExprBuilder::TYPE_BOOL; |
Member
Author
There was a problem hiding this comment.
this is the fix
the rest is code simplifications
nicolas-grekas
commented
Sep 26, 2025
| ->beforeNormalization() | ||
| ->ifArray() | ||
| ->then(static function ($v) { | ||
| $v += ['enabled' => true]; |
Member
Author
There was a problem hiding this comment.
we can rely on canBeEnabled/Disabled to set this default, but acceptAndWrap should then be moved earlier to have a proper ordering of beforeNormalization calls (adding [enabled => true] to wrapped strings)
…can be enabled or disabled
nicolas-grekas
force-pushed
the
config-pump
branch
from
bf1f204 to
633169f
Compare
Spomky
approved these changes
Sep 27, 2025
| $allowedTypes = $this->allowedTypes ?? $this->normalization->declaredTypes; | ||
| foreach ([$this->trueEquivalent, $this->falseEquivalent] as $equivalent) { | ||
| if (\is_array($equivalent) && $equivalent) { | ||
| $allowedTypes[] = ExprBuilder::TYPE_BOOL; |
GromNaN
reviewed
Sep 28, 2025
Member
GromNaN
left a comment
GromNaN
left a comment
There was a problem hiding this comment.
Can we add new tests to validate this new behavior?
Member
Author
|
no need for new tests, the existing updated one covers this |
GromNaN
approved these changes
Sep 28, 2025
fabpot
approved these changes
Sep 29, 2025
Member
|
Thank you @nicolas-grekas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing my journey on the config component, after #51273
That could be considered as a bugfix, but it's not worth fixing on lower branches because nobody is using this missing capability - by definition.
So: this allows doing eg
->lock(false)to disable locks, as expected when the node definition has->treatFalseLike(['enabled' => false])Note that I didn't turn
->treatNullLike(['enabled' => true])into acceptingnullas I don't see the point of allowing->lock(null)when one can use->lock(true).