[Config] Fix Yaml dumper for prototyped array with default null
#61800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
changed the title
null
GromNaN
commented
Sep 20, 2025
src/Symfony/Bundle/FrameworkBundle/Tests/Functional/ConfigDumpReferenceCommandTest.php
Show resolved
Hide resolved
src/Symfony/Component/Config/Definition/Dumper/YamlReferenceDumper.php
Outdated
Show resolved
Hide resolved
fabpot
approved these changes
Sep 21, 2025
GromNaN
force-pushed
the
config-null
branch
2 times, most recently
from
9ee8462 to
f8dc1d7
Compare
GromNaN
commented
Sep 21, 2025
Comment on lines
+118
to
+127
| #[TestWith(['yaml'])] | ||
| #[TestWith(['xml'])] | ||
| public function testDumpFrameworkBundle(string $format) | ||
| { | ||
| $tester = $this->createCommandTester(true); | ||
| $ret = $tester->execute(['name' => 'framework', '--format' => $format]); | ||
|
|
||
| $this->assertSame(0, $ret, 'Returns 0 in case of success'); | ||
| $this->assertStringContainsString('%env(default::SYMFONY_TRUSTED_PROXIES)%', $tester->getDisplay()); | ||
| } |
Member
Author
There was a problem hiding this comment.
This integration test increases the coverage of the (Yaml|Xml)ReferenceDumper classes with the configuration of the FrameworkBundle.
It's currently failing with "Unit Tests / Unit Tests (8.4, high-deps)" job because of the bug in the current symfony/config: 7.4@dev. That will be solved by merging this PR.
GromNaN
force-pushed
the
config-null
branch
from
f8dc1d7 to
54db22e
Compare
xabbuh
approved these changes
Sep 22, 2025
Member
|
Thank you @GromNaN. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command
config:dump-referencefails with theworkflow.events_to_dispatchoption. The default isnull, which is not accepted bycount().Bug introduced by #61718 (5ac6e74).